From owner-freebsd-fs@FreeBSD.ORG Sat Nov 22 17:56:26 2014 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B893FB35 for ; Sat, 22 Nov 2014 17:56:26 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2A53EE72 for ; Sat, 22 Nov 2014 17:56:25 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id sAMHuL7t099299 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 22 Nov 2014 19:56:21 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua sAMHuL7t099299 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id sAMHuK9O099298; Sat, 22 Nov 2014 19:56:20 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 22 Nov 2014 19:56:20 +0200 From: Konstantin Belousov To: Christoph Hellwig Subject: Re: RFC: patch to make d_fileno 64bits Message-ID: <20141122175620.GA17068@kib.kiev.ua> References: <20141121155754.GN17068@kib.kiev.ua> <420608613.5215411.1416613552066.JavaMail.root@uoguelph.ca> <20141122153427.GW17068@kib.kiev.ua> <20141122162201.GA27585@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141122162201.GA27585@infradead.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: FreeBSD Filesystems X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Nov 2014 17:56:26 -0000 On Sat, Nov 22, 2014 at 08:22:01AM -0800, Christoph Hellwig wrote: > On Sat, Nov 22, 2014 at 05:34:27PM +0200, Konstantin Belousov wrote: > > For syscalls 156 and 196 (and some more), the converter must be written > > in the vfs_syscalls.c which translates the new dirents into old dirents, > > at the level of best efforts. > > FYI, you might want to look at the high level construct we use for that > in Linux, where we pass a function pointer to format the dirent to the > VOP_READDIR equivalent. The function pointer is passed by the caller > and can format all kinds of different dirent stuctures. This hasn't > just been helpful for the 64bit ino dirent transition, but also for > foreign OS compatibility layers and in-kernel consumers like nfsd. Yes, this is very promising approach, I agree. Thank you for the pointer.