From owner-svn-src-all@freebsd.org Fri Nov 3 22:41:16 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F7D7E5CF89; Fri, 3 Nov 2017 22:41:16 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6B203768EB; Fri, 3 Nov 2017 22:41:16 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 873B23792; Fri, 3 Nov 2017 22:41:15 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id C353A2E55; Fri, 3 Nov 2017 22:41:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id PlhwTWg3LfU3; Fri, 3 Nov 2017 22:41:12 +0000 (UTC) Subject: Re: svn commit: r325116 - head DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com A5B362E50 To: Warner Losh Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" References: <201710300312.v9U3CcCT021416@repo.freebsd.org> <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org> Date: Fri, 3 Nov 2017 15:40:57 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8atGHB3OAANrBLIH0Vxcn7POljN0jWmap" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 22:41:16 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8atGHB3OAANrBLIH0Vxcn7POljN0jWmap Content-Type: multipart/mixed; boundary="F0thaUpI3tD43cS3KRQhVjs8FWFsX3N0f"; protected-headers="v1" From: Bryan Drewery To: Warner Losh Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org> Subject: Re: svn commit: r325116 - head References: <201710300312.v9U3CcCT021416@repo.freebsd.org> <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> In-Reply-To: --F0thaUpI3tD43cS3KRQhVjs8FWFsX3N0f Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/3/2017 3:32 PM, Warner Losh wrote: >=20 >=20 > On Fri, Nov 3, 2017 at 4:28 PM, Bryan Drewery > wrote: >=20 > On 10/29/2017 8:12 PM, Warner Losh wrote: > > Author: imp > > Date: Mon Oct 30 03:12:38 2017 > > New Revision: 325116 > > URL: https://svnweb.freebsd.org/changeset/base/325116 > > > > > Log: > >=C2=A0 =C2=A0Return proper status from buildenv. > > > >=C2=A0 =C2=A0make buildenv BUILDENV_SHELL=3D more us= eful. Remove '|| > >=C2=A0 =C2=A0true' from the command line so that errors are proper= ly > >=C2=A0 =C2=A0returned. There appears to be no reason for it, and i= t dates back to > >=C2=A0 =C2=A0the original commit by ru@. > > > >=C2=A0 =C2=A0Sponsored by: Netflix >=20 > Now simply running 'make buildenv' and 'exit' throws a make error. >=20 > Perhaps we need a BUILDENV_CMDS that does what you want and we othe= rwise > leave the ${BUILDENV_SHELL} || true handling. >=20 >=20 > Are you sure? >=20 > 4:29pm zooty:[242]> make buildenv > Entering world for amd64:amd64 > $ exit > 4:29pm zooty:[243]> >=20 > Perhaps you can give me an example that causes that? This was the very > first thing I checked before committing the fix... >=20 Only happens with zsh. > [root@c1100-1][pts/8][zsh/2][Fri 11/03/2017 15:40:10 PDT][0?2&] (git-sv= n)-[master]- > ~/git/freebsd # BUILDENV_SHELL=3Dcsh make buildenv > Entering world for amd64:amd64 > root@c1100-1:~/git/freebsd # exit > exit > ~/git/freebsd # BUILDENV_SHELL=3D/usr/local/bin/zsh make buildenv > Entering world for amd64:amd64 > For ZSH you must run: export CPUTYPE=3D > (buildenv) [root@c1100-1][pts/8][zsh/3][Fri 11/03/2017 15:40:23 PDT][1?= 0&] (git-svn)-[master]- > ~/git/freebsd # exit > *** Error code 1 >=20 > Stop. > make[1]: stopped in /root/git/freebsd > *** Error code 1 >=20 > Stop. > make: stopped in /root/git/freebsd --=20 Regards, Bryan Drewery --F0thaUpI3tD43cS3KRQhVjs8FWFsX3N0f-- --8atGHB3OAANrBLIH0Vxcn7POljN0jWmap Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZ/PB5AAoJEDXXcbtuRpfPpMcH/j6gmqnAORotHtqWXIRQfyjL 2gPfNg0EO+IQ7Z9chohZUfwMDaHGwzMhVi/sXJD1Voq3gtnftDSL8unxDd7Y7tRf vV/H57lSZnfnRvZfL1YnE30N2Sc4ZGnqQcAiDEFdpkTxuC2ZbC4uMwJkW9AWpLiD DGLFg1om4gyJblu8VZz0tI10Am7Jc+y4N0XB3SfkTRdD+wscPJpTBC0hbf1La5mZ dKEYpjIGnRU3WITXFRsr0+If9S4ifdaqIXI5P+dI5if6xiSLw8Fk9Ab99iIRALty CU9ztvauyawBUDS+T+l8DfU+mimnZ+5xa/G4uqaaf3HoZAys44DhjHxlZxnLPm0= =B5Ua -----END PGP SIGNATURE----- --8atGHB3OAANrBLIH0Vxcn7POljN0jWmap--