From owner-freebsd-bugs@FreeBSD.ORG  Sun Nov  4 12:20:02 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 651F2CA7
 for <freebsd-bugs@hub.freebsd.org>; Sun,  4 Nov 2012 12:20:02 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 4AF188FC0C
 for <freebsd-bugs@hub.freebsd.org>; Sun,  4 Nov 2012 12:20:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qA4CK1EQ000603
 for <freebsd-bugs@freefall.freebsd.org>; Sun, 4 Nov 2012 12:20:02 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qA4CK16J000602;
 Sun, 4 Nov 2012 12:20:01 GMT (envelope-from gnats)
Date: Sun, 4 Nov 2012 12:20:01 GMT
Message-Id: <201211041220.qA4CK16J000602@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Jilles Tjoelker <jilles@stack.nl>
Subject: Re: bin/113518: [patch] make(1): Prevent execution when command is a
 comment
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Jilles Tjoelker <jilles@stack.nl>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Nov 2012 12:20:02 -0000

The following reply was made to PR bin/113518; it has been noted by GNATS.

From: Jilles Tjoelker <jilles@stack.nl>
To: bug-followup@FreeBSD.org, ed@fxq.nl
Cc: sjg@FreeBSD.org
Subject: Re: bin/113518: [patch] make(1): Prevent execution when command is a
 comment
Date: Sun, 4 Nov 2012 13:11:58 +0100

 In PR bin/113518:
 > [patch to teach make about the shell's comment character]
 
 The first thing here is whether there are actually real-life Makefiles
 containing shell commands consisting only of comments. I only find a
 few in /usr/ports/Mk:
 
 jilles@jaguar /usr/ports/Mk% grep $'^[ \t]\\+#' *
 bsd.gecko.mk:   # XXX: make sure bsdtar(1) corrected symlinks
 bsd.kde4.mk:  # Check that the component is valid.
 bsd.kde4.mk:   # Skip meta-components (e.g., kdeprefix).
 bsd.kde4.mk:    # Check if a dependency type is explicitly requested.
 bsd.kde4.mk:    # If no dependency type is set, default to full dependency.
 bsd.kde4.mk:    # Set real dependencies.
 
 Likewise, there are only very few in src/**/Makefile* .
 
 It is unlikely that skipping the shell for these will give significant
 performance benefits.
 
 Secondly, I don't think such new features should be added to make(1)
 when it is planned to replace it with bmake (sjg@ cc'ed). Also, bmake
 generally knows less about the shell than make(1) does so it does not
 seem to fit in to add it to bmake.
 
 -- 
 Jilles Tjoelker