From nobody Wed Oct 13 18:18:47 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3B00317F7B93 for ; Wed, 13 Oct 2021 18:19:24 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HV15S14Khz4VQk for ; Wed, 13 Oct 2021 18:19:24 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id E570C29988 for ; Wed, 13 Oct 2021 18:19:23 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-qt1-f171.google.com with SMTP id t2so3431019qtx.8 for ; Wed, 13 Oct 2021 11:19:23 -0700 (PDT) X-Gm-Message-State: AOAM533IWXSWS+Ro+5DIEALDauK9fARZ1Zao2DOndw52MdveVr7krPX2 W0a1OAQNSb+mVeaWyEZX+AhSYUWSOwELAvgWKYOonw== X-Google-Smtp-Source: ABdhPJzZyCZVKr7xDynH0EQot1PDsMsO9/MLu7F6OgrpnsfgGcuO+aEo6xmieh8lOrFfs73EYej05/jMYfCSSMnATHY= X-Received: by 2002:ac8:8c:: with SMTP id c12mr1064904qtg.12.1634149163423; Wed, 13 Oct 2021 11:19:23 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202110121357.19CDvdWN002446@gitrepo.freebsd.org> <09c5ed72-fded-4282-b49f-6d494dff88b8@Canary> In-Reply-To: <09c5ed72-fded-4282-b49f-6d494dff88b8@Canary> From: Po-Chuan Hsieh Date: Thu, 14 Oct 2021 02:18:47 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 2bc3e6229feb - main - net-im/telegram-desktop: Update to 3.1.9 To: Dima Panov Cc: Alexey Dokuchaev , Li-Wen Hsu , "Sergey A. Osokin" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, ports-committers@freebsd.org Content-Type: multipart/alternative; boundary="00000000000065724705ce4000fc" X-ThisMailContainsUnwantedMimeParts: N --00000000000065724705ce4000fc Content-Type: text/plain; charset="UTF-8" On Thu, Oct 14, 2021 at 1:31 AM Dima Panov wrote: > Moin! > > Have tested the almost same patch. > Small suggestions: > > GTK_USE= GNOME=cairo gtk30 > Do you mean "GTK_USE= GNOME=cairo,gtk30" (use comma instead of space)? GTK_DESC= WebKit-gtk integration > > -- > Dima. (desktop, kde, x11, office, ports-secteam)@FreeBSD team > (fluffy@FreeBSD.org, https://t.me/dima_panov) > > On Wednesday, Oct 13, 2021 at 8:15 PM, Sergey A. Osokin > wrote: > Well, I'm not totally sure is my approach is corrent, but here's the > patch returning back GTK staff. Please be aware: it wasn't tested yet. > > -- > Sergey Osokin > > On Tue, Oct 12, 2021 at 02:31:35PM +0000, Alexey Dokuchaev wrote: > > On Tue, Oct 12, 2021 at 01:57:39PM +0000, Li-Wen Hsu wrote: > > commit 2bc3e6229febd07dd7f2980cb7065573d689a0f5 > > net-im/telegram-desktop: Update to 3.1.9 > > > Thanks for updating the port, however... > > ... > @@ -40,6 +39,7 @@ LIB_DEPENDS= libavformat.so:multimedia/ffmpeg \ > libpipewire-0.3.so:multimedia/pipewire \ > libqrcodegencpp.so:graphics/qr-code-generator \ > libusrsctp.so:net/libusrsctp \ > + libwebkit2gtk-4.0.so:www/webkit2-gtk3 \ > > > Commit log does not explain why would light-weight chat program would now > unconditionally depend on this admittedly quite heavy component. > > @@ -52,9 +52,10 @@ USE_GITHUB= nodefault > GH_ACCOUNT= telegramdesktop > GH_PROJECT= tdesktop > USE_GL= gl > -USE_GNOME= glib20 glibmm > +USE_GNOME= glib20 glibmm gtk30 > > > Nor does it explain why Qt-based program now unconditionally requires GTK. > > +INSTALLS_ICONS= yes > > > Please also see the latest CHANGES entry. > > ./danfe > > --00000000000065724705ce4000fc--