From owner-freebsd-multimedia@FreeBSD.ORG  Fri Feb  9 18:54:19 2007
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
X-Original-To: multimedia@freebsd.org
Delivered-To: freebsd-multimedia@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id ABF6A16A400
	for <multimedia@freebsd.org>; Fri,  9 Feb 2007 18:54:19 +0000 (UTC)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.freebsd.org (Postfix) with ESMTP id 9792113C4B3
	for <multimedia@freebsd.org>; Fri,  9 Feb 2007 18:54:19 +0000 (UTC)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.11/8.13.6) with ESMTP id l19IsE1N001764;
	Fri, 9 Feb 2007 10:54:14 -0800 (PST)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.11/8.12.3/Submit) id l19IsEIp001763;
	Fri, 9 Feb 2007 10:54:14 -0800 (PST) (envelope-from rizzo)
Date: Fri, 9 Feb 2007 10:54:14 -0800
From: Luigi Rizzo <rizzo@icir.org>
To: Jeremy Messenger <mezz7@cox.net>
Message-ID: <20070209105414.A1702@xorpc.icir.org>
References: <20070209073353.A99372@xorpc.icir.org>
	<op.tnhvnsg49aq2h7@mezz.mezzweb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <op.tnhvnsg49aq2h7@mezz.mezzweb.com>;
	from mezz7@cox.net on Fri, Feb 09, 2007 at 12:44:06PM -0600
Cc: mi@aldan.algebra.com, multimedia@freebsd.org
Subject: Re: vic patches for video4linux support
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Feb 2007 18:54:19 -0000

On Fri, Feb 09, 2007 at 12:44:06PM -0600, Jeremy Messenger wrote:
> On Fri, 09 Feb 2007 09:33:53 -0600, Luigi Rizzo <rizzo@icir.org> wrote:
...
> > + fix configure to look for videodev.h in the place where it is on
> >   FreeBSD, and disable v4l2 support for the time being as there
> >   is none as far as i know;
> 
> Disapprove because of hardcore. You should be replace from patch-configure  
> to REINPLACE_CMD with ${LOCALBASE}. Something like this (untest):

Thanks for looking at it.

will look at how to improve the patch, however what you suggest is
not enough in this case:
there are [at least] two instances of the match
pattern, one of which i want to replace, the other i do not.
(also consider that the source is basically dead - nobody
is going to change it so there is little point in being
flexible on the input).

...
> > + add -I/usr/local/include in the search path, for the above file;
> 
> Why? The CONFIGURE_ENV doesn't work?

will try it, thanks

cheers
luigi