From owner-svn-ports-head@FreeBSD.ORG Sat Jul 27 17:10:10 2013 Return-Path: Delivered-To: svn-ports-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 97211EB8; Sat, 27 Jul 2013 17:10:10 +0000 (UTC) (envelope-from ehaupt@critical.ch) Received: from mx.critical.ch (mx.critical.ch [62.2.45.171]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 308DE2CFB; Sat, 27 Jul 2013 17:10:09 +0000 (UTC) Received: from beaver.home.critical.ch (77-59-132-3.dclient.hispeed.ch [77.59.132.3]) (authenticated bits=0) by mx.critical.ch (8.14.5/8.14.5/critical-1.0) with ESMTP id r6RH9xZh004475; Sat, 27 Jul 2013 19:09:59 +0200 (CEST) (envelope-from ehaupt@critical.ch) Date: Sat, 27 Jul 2013 19:09:59 +0200 From: Emanuel Haupt To: John Marino Subject: Re: svn commit: r323632 - in head/audio: penguinsap xmms-sapplug Message-Id: <20130727190959.40558f7d87bd3a272cf291cc@critical.ch> In-Reply-To: <201307250938.r6P9ceF5061499@svn.freebsd.org> References: <201307250938.r6P9ceF5061499@svn.freebsd.org> X-Mailer: Sylpheed 3.3.0 (GTK+ 2.24.19; amd64-portbld-freebsd9.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jul 2013 17:10:10 -0000 John Marino wrote: > Author: marino > Date: Thu Jul 25 09:38:40 2013 > New Revision: 323632 > URL: http://svnweb.freebsd.org/changeset/ports/323632 > > Log: > audio/xmms-sapp, audio/penguinsap: Rework exception flags > > The wrong C++ flag, --no-exceptions, was being passed to these > ports. The correct flag is "-fno-exceptions". Apparently gcc > accepts the former, but clang does not. > > The current code states that clang version 3.2 will accept > --no-exceptions, but this isn't the case either. However, both of > these ports will build without a no-exceptions flag with clang. GCC > still requires it. > Rework the clang detection code. If code is not detected, > -fno-exceptions is added to CXXFLAGS, otherwise nothing is done. > Besides fixing the flag handling, this implemention avoids the bmake > errors that _CLANG!= was generating. > > Approved by: bapt (mentor), maintainer Thank you very much! Emanuel