Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Jul 2013 19:09:59 +0200
From:      Emanuel Haupt <ehaupt@critical.ch>
To:        John Marino <marino@FreeBSD.org>
Cc:        svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: svn commit: r323632 - in head/audio: penguinsap xmms-sapplug
Message-ID:  <20130727190959.40558f7d87bd3a272cf291cc@critical.ch>
In-Reply-To: <201307250938.r6P9ceF5061499@svn.freebsd.org>
References:  <201307250938.r6P9ceF5061499@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
John Marino <marino@FreeBSD.org> wrote:
> Author: marino
> Date: Thu Jul 25 09:38:40 2013
> New Revision: 323632
> URL: http://svnweb.freebsd.org/changeset/ports/323632
> 
> Log:
>   audio/xmms-sapp, audio/penguinsap: Rework exception flags
>   
>   The wrong C++ flag, --no-exceptions, was being passed to these
> ports.  The correct flag is "-fno-exceptions".  Apparently gcc
> accepts the former, but clang does not.
>   
>   The current code states that clang version 3.2 will accept
> --no-exceptions, but this isn't the case either.  However, both of
> these ports will build without a no-exceptions flag with clang.  GCC
> still requires it. 
>   Rework the clang detection code.  If code is not detected,
> -fno-exceptions is added to CXXFLAGS, otherwise nothing is done.
> Besides fixing the flag handling, this implemention avoids the bmake
> errors that _CLANG!= was generating.
>   
>   Approved by:	bapt (mentor), maintainer

Thank you very much!

Emanuel



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130727190959.40558f7d87bd3a272cf291cc>