From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 12 02:40:24 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 591E416A4CE for ; Sun, 12 Sep 2004 02:40:24 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3EA0443D45 for ; Sun, 12 Sep 2004 02:40:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8C2eOgc086957 for ; Sun, 12 Sep 2004 02:40:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8C2eOix086956; Sun, 12 Sep 2004 02:40:24 GMT (envelope-from gnats) Resent-Date: Sun, 12 Sep 2004 02:40:24 GMT Resent-Message-Id: <200409120240.i8C2eOix086956@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DF17516A4CE for ; Sun, 12 Sep 2004 02:37:40 +0000 (GMT) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id B463A43D48 for ; Sun, 12 Sep 2004 02:37:39 +0000 (GMT) (envelope-from dan@obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8C2bc9q007097 for ; Sun, 12 Sep 2004 04:37:38 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8C2bb7V007096 for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 04:37:37 +0200 (CEST) (envelope-from dan@obluda.cz) Message-Id: <200409120237.i8C2bb7V007096@kulesh.obluda.cz> Date: Sun, 12 Sep 2004 04:37:37 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/71618: [PATCH] cleanup of the usr.sbin/timed code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 02:40:24 -0000 >Number: 71618 >Category: bin >Synopsis: [PATCH] cleanup of the usr.sbin/timed code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 12 02:40:23 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.3-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386 src/usr.sbin/timed/timed/readmsg.c,v 1.9 2001/11/20 07:13:40 jhb src/usr.sbin/timed/timed/master.c,v 1.9 2002/07/11 20:01:36 robert >Description: There are more than 5000 warnings issued during "make buildworld". Some of them are false positives, but some of them are sign of true errors. Nobody is upset by warnings due it's amount, so some errors remain uncorrected. I want to cleanup the code-base from warnings, so warnings will become "attention mark" again. usr.sbin/timed/timed/master.c:340: warning: no return statement in function returning non-void usr.sbin/timed/timed/readmsg.c:501: warning: long int format, int32_t arg (arg 6) usr.sbin/timed/timed/readmsg.c:501: warning: long int format, int32_t arg (arg 7) >How-To-Repeat: N/A >Fix: *** usr.sbin/timed/timed/master.c.ORIG Mon Jul 15 02:11:08 2002 --- usr.sbin/timed/timed/master.c Mon Sep 6 02:22:26 2004 *************** *** 337,342 **** --- 337,343 ---- } } goto loop; + return(0); } *** usr.sbin/timed/timed/readmsg.c.ORIG Tue Nov 20 08:13:40 2001 --- usr.sbin/timed/timed/readmsg.c Mon Sep 6 02:20:20 2004 *************** *** 491,497 **** break; case TSP_ADJTIME: ! fprintf(fd, "%s %d %-6u (%ld,%ld) %-15s %s\n", tsptype[msg->tsp_type], msg->tsp_vers, msg->tsp_seq, --- 491,497 ---- break; case TSP_ADJTIME: ! fprintf(fd, "%s %d %-6u (%d,%d) %-15s %s\n", tsptype[msg->tsp_type], msg->tsp_vers, msg->tsp_seq, >Release-Note: >Audit-Trail: >Unformatted: