From owner-svn-ports-all@FreeBSD.ORG  Sat Jul 27 17:10:48 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 5EDC710C;
 Sat, 27 Jul 2013 17:10:48 +0000 (UTC)
 (envelope-from andrej.zverev@gmail.com)
Received: from mail-ob0-x230.google.com (mail-ob0-x230.google.com
 [IPv6:2607:f8b0:4003:c01::230])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 023562D04;
 Sat, 27 Jul 2013 17:10:47 +0000 (UTC)
Received: by mail-ob0-f176.google.com with SMTP id v19so6648622obq.35
 for <multiple recipients>; Sat, 27 Jul 2013 10:10:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=JmDBvR6AbbWT29XNzvOg/JzKi+OrHX+QPsXmLICocfY=;
 b=cZRaJqpzL0w7aCKYAoBqnBtUnZmhkX6Tz4fAqxH1zC9zziEsTm0KAb9r/J6JbIxh9f
 C5S4ipHyyBHPAMCj2nAu/BRHT/GLxrWKS2erAw6GtklcKgxQJ09soMC6olbGO7rARbx8
 KE2XGPg0xun3W/4FOWBZ/vMFjk2EMxuOmqIuLyvZpz/EXnyAQcjL/KSWrfceZDE4AxtL
 q7KNW3Wid6Lcr1eALxToO8S7NLbe6Vk+U+8cxc/onLJ9v/+4I6WJ+18KDdXEkX8C7++O
 AbIaxWgMfFXxAlTaY4zUtwv1SIyC0OjPry1MwNd+bGztWnCWqxzd+7bn/jKTYUQpJLBx
 GhAw==
MIME-Version: 1.0
X-Received: by 10.182.28.98 with SMTP id a2mr45606563obh.36.1374945047258;
 Sat, 27 Jul 2013 10:10:47 -0700 (PDT)
Sender: andrej.zverev@gmail.com
Received: by 10.182.118.100 with HTTP; Sat, 27 Jul 2013 10:10:47 -0700 (PDT)
In-Reply-To: <20130727162504.GA78281@FreeBSD.org>
References: <201307271606.r6RG6PoL038173@svn.freebsd.org>
 <20130727162504.GA78281@FreeBSD.org>
Date: Sat, 27 Jul 2013 21:10:47 +0400
X-Google-Sender-Auth: Deaos1Z-7cMvSXlhRw3ixiLRTbs
Message-ID: <CAD5bB+jewTn+B301gtkr1BVmSQsU+D7wy2We=bcd5ZsX=2y-cw@mail.gmail.com>
Subject: Re: svn commit: r323795 - in head: audio/mp32ogg audio/p5-Shout
 databases/p5-DBD-InterBase databases/p5-DBIx-Class-TimeStamp
 databases/p5-DBIx-MySQLSequence devel/cvslines devel/cvsplot devel/cvsstat
 d...
From: Andrej Zverev <az@freebsd.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Jul 2013 17:10:48 -0000

On Sat, Jul 27, 2013 at 8:25 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Sat, Jul 27, 2013 at 04:06:25PM +0000, Andrej Zverev wrote:
>> New Revision: 323795
>> URL: http://svnweb.freebsd.org/changeset/ports/323795
>>
>> @@ -32,7 +29,7 @@ NO_BUILD=   yes
>>  PLIST_FILES= bin/mp32ogg
>>
>>  post-patch:
>> -     @${PERL} -pi -e "s,%%LOCALBASE%%,${LOCALBASE},g" ${WRKSRC}/mp32ogg
>> +     @${REINPLACE_CMD} -i '' -e 's|%%LOCALBASE%%|${LOCALBASE}|' ${WRKSRC}/mp32ogg
>
> Andrej, can you clarify why explicit -i '' is needed here and quite a few
> other ports in the commit?  Is it because of otherwise .bak files will be
> installed?  Just looks weird to see these args all over the place...

Yes, thats a reason. I don't see (personally) why REPLACE ARGS default
with -i.bak,
but overriding port Makefile everytime really annoying :(