From owner-svn-src-all@freebsd.org Sat Oct 17 18:25:59 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DBE0EA1725F for ; Sat, 17 Oct 2015 18:25:59 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B4AC0FDC for ; Sat, 17 Oct 2015 18:25:59 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound2.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Sat, 17 Oct 2015 18:26:01 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t9HIPoKl006306; Sat, 17 Oct 2015 12:25:50 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1445106350.71631.36.camel@freebsd.org> Subject: Re: svn commit: r289421 - in head/etc: . mtree ntp From: Ian Lepore To: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sat, 17 Oct 2015 12:25:50 -0600 In-Reply-To: <201510161404.t9GE4GqM046436@repo.freebsd.org> References: <201510161404.t9GE4GqM046436@repo.freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2015 18:26:00 -0000 On Fri, 2015-10-16 at 14:04 +0000, Cy Schubert wrote: > Author: cy > Date: Fri Oct 16 14:04:16 2015 > New Revision: 289421 > URL: https://svnweb.freebsd.org/changeset/base/289421 > > Log: > Add default leap-seconds file. This should help ntp networks get > the > leap second date correct > > Updates to the file can be obtained from ftp://time.nist.gov/pub/ o > r > ftp://tycho.usno.navy.mil/pub/ntp/. > > Suggested by: dwmalone > Reviewed by: roberto, dwmalone, delphij > Approved by: roberto > MFC after: 1 week One thing about this change scares me. In the ntpd documentation: If the leapseconds file is present, the leap bits for reference clocks and downstratum servers are ignored. I can't determine from casual code examination (and I don't have time to experiment now) whether that is true even if the file is expired. The leapfile expires every six months, and users must update it using some external mechanism, or they must have configured autokey stuff so that updates can be accepted from peer servers. In either case what we've done is created a default configuration that is likely to fail right out of the box, because at least for releases the file we deliver will be expired before they even download and install the image. At the very least I think we should hold off on MFC of this until we know for sure whether an expired-but-present leapfile causes incorrect operation. If a pending leap notification in the leap bits of packets from peer servers and refclocks will be honored when the file is expired, then there is no problem with this change. -- Ian