From nobody Fri Dec 29 19:43:07 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1wlq3F46z554pG; Fri, 29 Dec 2023 19:43:19 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1wlq1XX9z3MGd; Fri, 29 Dec 2023 19:43:19 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-7cc94f8756aso1057229241.0; Fri, 29 Dec 2023 11:43:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703878998; x=1704483798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YN5dP8/UnY2fAI1U+uum6CAU9YDWSVV9ayheMT559MA=; b=OEguD+YECfAv5NQlm29MuaLi9uLHq9CHpiYikFh21kwt+hkl0dnBcz2DldVOxnD1UU ozImc3NbC6ivNMjNlMSebn8iE9jp1liJUVVnWugHNP3E4+738i3m+dIJdRYLNgf5NVDe UvHIJF89iIMc4xPoyWRH97QNm0Qa8NGMHaaIKKFyCFLma49Cgtd43lQrVNhLgfpnKJyU OKR4xHgiiRYdiOWlXg1dS9Y6jMREcMbiXJaw6M5lE3+2YLneIbhi7G2SHtNail1AAzyi Dnt1f51aNds4t2G6qBiPFTud6tJQZGLJpM4ymgyAnMLWt145VbfrnICA6I1z53dqbKdW haOQ== X-Gm-Message-State: AOJu0Yykgj9mJD5pcBM5/0PfgLML/9dCfvJVnWkzBRAeUf7VBUDK0179 EmdkdS2fgv2aDmUNNHX/5bYLAHTO0rMY7NUD23i1Vy0dPOg= X-Google-Smtp-Source: AGHT+IGqlWl64IMH9RVdt78tJHGKV4nMugAIXNLhc98K29bgDJ0DTwrv0i+uzAHGkd8AktdWF2qV/vp9KVf9wNIujAc= X-Received: by 2002:ac5:c396:0:b0:4b6:bee9:3cbd with SMTP id s22-20020ac5c396000000b004b6bee93cbdmr3943483vkk.5.1703878997964; Fri, 29 Dec 2023 11:43:17 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202312270143.3BR1hMQf085312@gitrepo.freebsd.org> <24134FF7-8C03-490D-A476-4EFF4EAD8132@FreeBSD.org> <0452FE2C-00E9-4E06-880B-6F7B56751728@FreeBSD.org> In-Reply-To: From: Antoine Brodin Date: Fri, 29 Dec 2023 19:43:07 +0000 Message-ID: Subject: Re: git: a8b70cf26030 - main - netpfil: Use accessor functions and named constants for all tcphdr flags To: Warner Losh Cc: Dimitry Andric , Gleb Smirnoff , Richard Scheffenegger , src-committers , "" , "" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4T1wlq1XX9z3MGd On Fri, Dec 29, 2023 at 7:33=E2=80=AFPM Warner Losh wrote: > On Fri, Dec 29, 2023, 4:39=E2=80=AFAM Dimitry Andric wr= ote: >> >> On 29 Dec 2023, at 11:17, Dimitry Andric wrote: >> > >> > On 29 Dec 2023, at 08:35, Antoine Brodin wrote: >> >> >> >> On Thu, Dec 28, 2023 at 10:37=E2=80=AFPM Gleb Smirnoff wrote: >> >>> >> >>> Antoine, >> >>> >> >>> On Thu, Dec 28, 2023 at 08:48:36PM +0000, Antoine Brodin wrote: >> >>> A> > netpfil: Use accessor functions and named constants for all= tcphdr flags >> >>> A> > >> >>> ... >> >>> A> This breaks some ports: >> >>> A> /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline= ' >> >>> >> >>> Definitely some ports that use some strange compilers :) >> >>> >> >>> Can you please give at least port names? >> >> >> >> Some examples: >> >> >> >> https://pkg-status.freebsd.org/gohan04/data/mainamd64PR275986-default= -foo/2023-12-28_20h35m41s/logs/errors/nspr-4.35.log >> >> https://pkg-status.freebsd.org/gohan04/data/mainamd64PR275986-default= -foo/2023-12-28_20h35m41s/logs/errors/opusfile-0.12_1.log >> > >> > The culprit is likely the "-ansi" option. Just get rid of that, it is = not really useful: >> > >> > cc -o prmapopt.o -c -fvisibility=3Dhidden -O2 -pipe -fstack-protector-= strong -fno-strict-aliasing -ansi -Wall -fPIC -UDEBUG -DPACKAGE_NAME=3D\"\"= -DPACKAGE_TARNAME=3D\"\" -DPACKAGE_VERSION=3D\"\" -DPACKAGE_STRING=3D\"\" = -DPACKAGE_BUGREPORT=3D\"\" -DPACKAGE_URL=3D\"\" -DNDEBUG=3D1 -DHAVE_VISIBIL= ITY_HIDDEN_ATTRIBUTE=3D1 -DHAVE_VISIBILITY_PRAGMA=3D1 -DXP_UNIX=3D1 -DFREEB= SD=3D1 -DHAVE_BSD_FLOCK=3D1 -DHAVE_SOCKLEN_T=3D1 -DHAVE_POINTER_LOCALTIME_R= =3D1 -DHAVE_DLADDR=3D1 -DHAVE_LCHOWN=3D1 -DHAVE_SETPRIORITY=3D1 -DHAVE_STRE= RROR=3D1 -DHAVE_SYSCALL=3D1 -DHAVE_SECURE_GETENV=3D1 -D_REENTRANT=3D1 -D_TH= READ_SAFE=3D1 -DFORCE_PR_LOG -D_PR_PTHREADS -UHAVE_CVAR_BUILT_ON_SEM -D_NSP= R_BUILD_ -I../../../dist/include/nspr -I../../../pr/include -I../../../pr/i= nclude/private prmapopt.c >> > In file included from prmapopt.c:46: >> > In file included from prmapopt.c:46: >> > /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline' >> > 82 | static inline uint16_t >> > | ^ >> >> Hm, I may have spoken too soon here. If this port has always compiled su= ccessfully with -ansi, then indeed it may not be that handy to directly use= the 'inline' keyword in system headers. I think most other system headers = use '__inline', which is supported by both gcc and clang, even in ANSI mode= . And if the compiler somehow does not support __inline, sys/cdefs.h can ma= ke sure all those keywords get removed. > > > Yes. You have to use __inline in system headers. Yes I confirm that using __inline instead of inline fixes both nspr and opusfile. Antoine