Date: Fri, 29 Dec 2023 19:43:07 +0000 From: Antoine Brodin <antoine@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Dimitry Andric <dim@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, Richard Scheffenegger <rscheff@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: a8b70cf26030 - main - netpfil: Use accessor functions and named constants for all tcphdr flags Message-ID: <CAALwa8mu3HBm8esrzaSWGQzDFkDyfNEhWHjvfLh1ZRz5XfEHHQ@mail.gmail.com> In-Reply-To: <CANCZdfqgptdx7OzgbCyozvvPLBeA0MxDwFQUW6R=oSP_QPHunQ@mail.gmail.com> References: <202312270143.3BR1hMQf085312@gitrepo.freebsd.org> <CAALwa8n%2BSs397icBLsYEPZM0ynnou=1Kxc5dV5FAa_CofjpT4A@mail.gmail.com> <ZY34hIExot089sPR@FreeBSD.org> <CAALwa8nf3x6ipG3hBv%2B3j0cHyYq%2BiGUjeMOW1qip%2BNMAXaZL%2Bw@mail.gmail.com> <24134FF7-8C03-490D-A476-4EFF4EAD8132@FreeBSD.org> <0452FE2C-00E9-4E06-880B-6F7B56751728@FreeBSD.org> <CANCZdfqgptdx7OzgbCyozvvPLBeA0MxDwFQUW6R=oSP_QPHunQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 29, 2023 at 7:33=E2=80=AFPM Warner Losh <imp@bsdimp.com> wrote: > On Fri, Dec 29, 2023, 4:39=E2=80=AFAM Dimitry Andric <dim@freebsd.org> wr= ote: >> >> On 29 Dec 2023, at 11:17, Dimitry Andric <dim@FreeBSD.org> wrote: >> > >> > On 29 Dec 2023, at 08:35, Antoine Brodin <antoine@FreeBSD.org> wrote: >> >> >> >> On Thu, Dec 28, 2023 at 10:37=E2=80=AFPM Gleb Smirnoff <glebius@freeb= sd.org> wrote: >> >>> >> >>> Antoine, >> >>> >> >>> On Thu, Dec 28, 2023 at 08:48:36PM +0000, Antoine Brodin wrote: >> >>> A> > netpfil: Use accessor functions and named constants for all= tcphdr flags >> >>> A> > >> >>> ... >> >>> A> This breaks some ports: >> >>> A> /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline= ' >> >>> >> >>> Definitely some ports that use some strange compilers :) >> >>> >> >>> Can you please give at least port names? >> >> >> >> Some examples: >> >> >> >> https://pkg-status.freebsd.org/gohan04/data/mainamd64PR275986-default= -foo/2023-12-28_20h35m41s/logs/errors/nspr-4.35.log >> >> https://pkg-status.freebsd.org/gohan04/data/mainamd64PR275986-default= -foo/2023-12-28_20h35m41s/logs/errors/opusfile-0.12_1.log >> > >> > The culprit is likely the "-ansi" option. Just get rid of that, it is = not really useful: >> > >> > cc -o prmapopt.o -c -fvisibility=3Dhidden -O2 -pipe -fstack-protector-= strong -fno-strict-aliasing -ansi -Wall -fPIC -UDEBUG -DPACKAGE_NAME=3D\"\"= -DPACKAGE_TARNAME=3D\"\" -DPACKAGE_VERSION=3D\"\" -DPACKAGE_STRING=3D\"\" = -DPACKAGE_BUGREPORT=3D\"\" -DPACKAGE_URL=3D\"\" -DNDEBUG=3D1 -DHAVE_VISIBIL= ITY_HIDDEN_ATTRIBUTE=3D1 -DHAVE_VISIBILITY_PRAGMA=3D1 -DXP_UNIX=3D1 -DFREEB= SD=3D1 -DHAVE_BSD_FLOCK=3D1 -DHAVE_SOCKLEN_T=3D1 -DHAVE_POINTER_LOCALTIME_R= =3D1 -DHAVE_DLADDR=3D1 -DHAVE_LCHOWN=3D1 -DHAVE_SETPRIORITY=3D1 -DHAVE_STRE= RROR=3D1 -DHAVE_SYSCALL=3D1 -DHAVE_SECURE_GETENV=3D1 -D_REENTRANT=3D1 -D_TH= READ_SAFE=3D1 -DFORCE_PR_LOG -D_PR_PTHREADS -UHAVE_CVAR_BUILT_ON_SEM -D_NSP= R_BUILD_ -I../../../dist/include/nspr -I../../../pr/include -I../../../pr/i= nclude/private prmapopt.c >> > In file included from prmapopt.c:46: >> > In file included from prmapopt.c:46: >> > /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline' >> > 82 | static inline uint16_t >> > | ^ >> >> Hm, I may have spoken too soon here. If this port has always compiled su= ccessfully with -ansi, then indeed it may not be that handy to directly use= the 'inline' keyword in system headers. I think most other system headers = use '__inline', which is supported by both gcc and clang, even in ANSI mode= . And if the compiler somehow does not support __inline, sys/cdefs.h can ma= ke sure all those keywords get removed. > > > Yes. You have to use __inline in system headers. Yes I confirm that using __inline instead of inline fixes both nspr and opusfile. Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8mu3HBm8esrzaSWGQzDFkDyfNEhWHjvfLh1ZRz5XfEHHQ>