From nobody Mon Mar 31 19:14:38 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZRLRd2lshz5sRPY for ; Mon, 31 Mar 2025 19:14:53 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZRLRc29rxz3MJQ for ; Mon, 31 Mar 2025 19:14:52 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43cfb6e9031so43880325e9.0 for ; Mon, 31 Mar 2025 12:14:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743448490; x=1744053290; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lpizo2OwMi+XLl0pQ13vqszssQcb/KqimIYqrBm2c4s=; b=QCXqPWyRjCop3qdxyJgJoFvM4FjVopClxU+JNhfHqR98W6/JHrfPQItULigrWnjKbA OU4ylJk+3f/hOBYLrML4tooW4XuxCr3MrjFaI12/ureCLVI2wY8G7JFQhR4CtRPS2CyX Bf4Bo0Xztb3iKELoykWdmMq9u0oGnCgcgJfAtxmLQjFmiMLDSUiEiHKQudvEjA4hYq/5 +/PqZgdtyeXiEVUPpge47Uq9m6WkRmuDgv19f4NnjMnYq514vy6O0oW76LGX2G2HLT2V vArEZ9sUtBfHt1RUSH+bwVzHdAFszhIKPnfgAw5IrI4FnIaLsC7a4kdIJ+AVymajFGzM uZZQ== X-Forwarded-Encrypted: i=1; AJvYcCVQ+F+WrP/Iq7Id3XPoklucfT8ntUObQxR+xPRc2SFP+Ep1wgUyylneKoK7TcVNhs8weQ4nctghbWsWqDKx8ZF0ntnINQ==@freebsd.org X-Gm-Message-State: AOJu0Yxe6K3cmyggCpzPJMM+h+QheJn97yD+UfUknj/7p4tytLko/EaW KbpP79CR9ZDh6kzZTGJHVO5hNREXIZynDKDA+ugeujQ9n3TumFf+LRkHwj9Oyixj1ShVN7HUlpx e X-Gm-Gg: ASbGncu1zTvO/IjOGPtEac9CuFemNEZqclsTFiO9t6GL/j2w564Hok5yUvBX1U+xBDC Lv8+PRGKX7c5VUP09BCxxqkyZpq3Pc6JEGx1qwuKiJMQKqZOHUO9XlbPUnBKdHA1ydUSKC52HuB R9Cycpw4bOUevByhMhhADknbP2TRi1uxXYn8/Mgdc2fc9eG/9VlckBAOaUlmqKrOd33u+b4DehM 0cjwjFLVprpUPL8WqCtOUxEcNRVNkRj/i+KLF22E76M6ivQautwo8Xt4VqQhHo44NHzlJ88YntG wwDr4Y5LmGdrFHhWjCXz/WVUCUH14q/1pW1LyCcspptk6boQrHT8b9HcHNXCzEg2iD3Mjw== X-Google-Smtp-Source: AGHT+IHOhkc2kYVm9Wjh0IIAq3Zv6g7qTx5Huz6nefadVxaHauRYfLGWOMGTRsRC+0cJPzqyaqKYig== X-Received: by 2002:a05:600c:34c1:b0:43d:b85:1831 with SMTP id 5b1f17b1804b1-43dabe240cemr111495185e9.0.1743448490375; Mon, 31 Mar 2025 12:14:50 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d82e6a532sm172788125e9.9.2025.03.31.12.14.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Mar 2025 12:14:49 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: git: 0e33c2e6df7a - main - pci: Only re-route IRQs based on firmware on x86 From: Jessica Clarke In-Reply-To: <202503292018.52TKI7va048377@gitrepo.freebsd.org> Date: Mon, 31 Mar 2025 20:14:38 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202503292018.52TKI7va048377@gitrepo.freebsd.org> To: Colin Percival X-Mailer: Apple Mail (2.3826.300.87.4.3) X-Spamd-Result: default: False [3.40 / 15.00]; NEURAL_SPAM_LONG(1.00)[1.000]; NEURAL_SPAM_MEDIUM(0.84)[0.839]; RBL_SENDERSCORE_REPUT_7(0.50)[209.85.128.45:from]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; NEURAL_SPAM_SHORT(0.16)[0.158]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; BAD_REP_POLICIES(0.10)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEFALL_USER(0.00)[jrtc27]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TO_MATCH_ENVRCPT_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.45:from]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_NA(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17:c]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.45:from]; FROM_HAS_DN(0.00)[] X-Rspamd-Queue-Id: 4ZRLRc29rxz3MJQ X-Spamd-Bar: +++ On 29 Mar 2025, at 20:18, Colin Percival wrote: >=20 > The branch main has been updated by cperciva: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D0e33c2e6df7a5de65db40c7cc0fc97f6= 6da28ccd >=20 > commit 0e33c2e6df7a5de65db40c7cc0fc97f66da28ccd > Author: Colin Percival > AuthorDate: 2025-03-28 18:07:01 +0000 > Commit: Colin Percival > CommitDate: 2025-03-29 20:17:29 +0000 >=20 > pci: Only re-route IRQs based on firmware on x86 >=20 > There is a (very historical) call to pci_assign_interrupt for the > purpose of routing IRQs which may have been set up wrong by x86 = BIOS > or firmware. On non-x86 systems, this is unnecessary; and on = INTRNG > systems it results in a (synthetic) IRQ leak and ultimately a = kernel > panic after many hotplug/unplug cycles. This is in fact incorrect. Whilst there may well be a leak that needs fixing, the rerouting is absolutely needed on non-x86 platforms. See 5884fab46153dee52bda660bcabca95c3cc97f44 and 7de649170fd804668da78f005c7966941b402106 for some of the history behind this. As a result of this commit the problem described in the second commit is reintroduced. Jess > Suggested by: jhb > Reviewed by: jhb > MFC after: 2 weeks > Sponsored by: Amazon > Differential Revision: https://reviews.freebsd.org/D49560 > --- > sys/dev/pci/pci.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/sys/dev/pci/pci.c b/sys/dev/pci/pci.c > index fe99d6beb029..3a51e4c38296 100644 > --- a/sys/dev/pci/pci.c > +++ b/sys/dev/pci/pci.c > @@ -4175,6 +4175,7 @@ pci_add_resources(device_t bus, device_t dev, = int force, uint32_t prefetchmask) > if (q->devid =3D=3D devid && q->type =3D=3D PCI_QUIRK_MAP_REG) > pci_add_map(bus, dev, q->arg1, rl, force, 0); >=20 > +#if defined(__i386__) || defined(__amd64__) > if (cfg->intpin > 0 && PCI_INTERRUPT_VALID(cfg->intline)) { > /* > * Try to re-route interrupts. Sometimes the BIOS or > @@ -4184,6 +4185,7 @@ pci_add_resources(device_t bus, device_t dev, = int force, uint32_t prefetchmask) > */ > pci_assign_interrupt(bus, dev, 1); > } > +#endif >=20 > if (pci_usb_takeover && pci_get_class(dev) =3D=3D PCIC_SERIALBUS && > pci_get_subclass(dev) =3D=3D PCIS_SERIALBUS_USB) {