From owner-svn-src-all@freebsd.org  Thu Apr 21 17:09:50 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EEEA5B171DB;
 Thu, 21 Apr 2016 17:09:50 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: from mail-lb0-x22d.google.com (mail-lb0-x22d.google.com
 [IPv6:2a00:1450:4010:c04::22d])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 91A77185D;
 Thu, 21 Apr 2016 17:09:50 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: by mail-lb0-x22d.google.com with SMTP id b1so27072677lbi.1;
 Thu, 21 Apr 2016 10:09:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc; bh=h/+N5nd3Uselza9CngxDvaeGfxFmpsOm86kTEWW3IqY=;
 b=H0qBvpnfs4Vb0uJdvYr48jDySXexMBbtgnJrkAurn4kftTh6NzBRLjOXwIjdE/c1e3
 LNJcoWi9eiJ6ZFs6IR49u3r1JKvmP0Lf3jJzXnrZJXxZbuCeN7wmMpXlXwEzIn8cm5TO
 gedX7ENSNgxe53psYWsbNKPKmjouCPt28IJTt28nHeNJQFTbUbQHSjRzcSYr/5avc26j
 o7gTn64oUIeN1Nqy7PY9dva8wrPp6090jl7Yw2cR8rvpzOEKbmjEvWPTUyw/L96IvQjn
 pvmuuD4zLmv4m17hkGQKm8rwse9COVGgU76YZrQGt1fihQzW6ki6Q+tK5YLCbpd4jmKM
 LiXg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc;
 bh=h/+N5nd3Uselza9CngxDvaeGfxFmpsOm86kTEWW3IqY=;
 b=JOij36yDNq7xEZBq8VdoexMJv5bw13kOuT2YoqWQOkGMS+DwGGm5irWDREwUKUC/PC
 mQEiIam7m6xqDp81WdLJxAQZXDHqL6Prp9ecXq7Bq8oQ6WsiU6aOKr33Ng8c0/lvIpI2
 kzc/Wd6SZvTe3d5XOF9LNr4DpOeCdZzdw9lt+j+cHTMQXm7bLSJku7zqL8rZiWBaCuVL
 97aTQSxap5jc7VHaitz4BGxFiN+GaJu1VnyZ2tRb1NvLprlKHtfbpVgNBmMDuBbaSKv+
 kQpHFutuXVG8sr1YnSv2ALIlsNG4/FrjAZ3fqsdz9GG3eDxIAmwpoMvidSBjsjVgFYFM
 d/+g==
X-Gm-Message-State: AOPr4FUszCHZZUlgvt4AU7Nwy94yW6T4b/gbXTtlLhPFu8ZRvu/npbu8MWRyPmtjBXd3JpZSJHAv4i+dxoC3Dg==
MIME-Version: 1.0
X-Received: by 10.112.171.74 with SMTP id as10mr3133475lbc.139.1461258588771; 
 Thu, 21 Apr 2016 10:09:48 -0700 (PDT)
Received: by 10.112.236.33 with HTTP; Thu, 21 Apr 2016 10:09:48 -0700 (PDT)
In-Reply-To: <CAGHfRMCj5zQUHddyoY8Vn2qxJyjV7sUHYDK+0Jg2SCCiFX6_Sw@mail.gmail.com>
References: <201604211643.u3LGhFpR057982@repo.freebsd.org>
 <CAGHfRMCj5zQUHddyoY8Vn2qxJyjV7sUHYDK+0Jg2SCCiFX6_Sw@mail.gmail.com>
Date: Thu, 21 Apr 2016 10:09:48 -0700
Message-ID: <CAGHfRMBm5RtfC8qk17snHvzEDchh0miizWOqR1srH_cFt7rb9Q@mail.gmail.com>
Subject: Re: svn commit: r298420 - head/sys/geom
From: Ngie Cooper <yaneurabeya@gmail.com>
To: Alan Somers <asomers@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Apr 2016 17:09:51 -0000

On Thu, Apr 21, 2016 at 10:08 AM, Ngie Cooper <yaneurabeya@gmail.com> wrote:
> On Thu, Apr 21, 2016 at 9:43 AM, Alan Somers <asomers@freebsd.org> wrote:
>> Author: asomers
>> Date: Thu Apr 21 16:43:15 2016
>> New Revision: 298420
>> URL: https://svnweb.freebsd.org/changeset/base/298420
>>
>> Log:
>>   Notify userspace listeners when geom disk attributes have changed
>>
>>   sys/geom/geom_disk.c:
>>         disk_attr_changed(): Generate a devctl event of type GEOM:<attr> for
>>         every call.
>>
>>   MFC after:    4 weeks
>>   Sponsored by: Spectra Logic Corp
>>   Differential Revision:        https://reviews.freebsd.org/D5952
>>
>> Modified:
>>   head/sys/geom/geom_disk.c
>>
>> Modified: head/sys/geom/geom_disk.c
>> ==============================================================================
>> --- head/sys/geom/geom_disk.c   Thu Apr 21 16:33:42 2016        (r298419)
>> +++ head/sys/geom/geom_disk.c   Thu Apr 21 16:43:15 2016        (r298420)
>> @@ -43,6 +43,7 @@ __FBSDID("$FreeBSD$");
>>  #include <sys/kernel.h>
>>  #include <sys/sysctl.h>
>>  #include <sys/bio.h>
>> +#include <sys/bus.h>
>>  #include <sys/ctype.h>
>>  #include <sys/fcntl.h>
>>  #include <sys/malloc.h>
>> @@ -839,11 +840,14 @@ disk_attr_changed(struct disk *dp, const
>>  {
>>         struct g_geom *gp;
>>         struct g_provider *pp;
>> +       char devnamebuf[128];
>
> Why 128? Also, why not sbuf?
>
>>         gp = dp->d_geom;
>>         if (gp != NULL)
>>                 LIST_FOREACH(pp, &gp->provider, provider)
>>                         (void)g_attr_changed(pp, attr, flag);
>> +       snprintf(devnamebuf, 128, "devname=%s%d", dp->d_name, dp->d_unit);
>
> Why not sizeof(devnamebuf) ?

Also: this doesn't NUL terminate devnamebuf; it really should
(otherwise, boom... crash in geom)...