Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Feb 2008 23:09:41 +0100
From:      Kris Kennaway <kris@FreeBSD.org>
To:        Brett Bump <bbump@rsts.org>, kib@FreeBSD.org
Cc:        freebsd-performance@FreeBSD.org, Mike Tancsa <mike@sentex.net>
Subject:   Re: System perforamance 4.x vs. 5.x and 6.x
Message-ID:  <47BB53A5.30100@FreeBSD.org>
In-Reply-To: <20080219145105.C96725@mail.rsts.org>
References:  <20080214114759.R75215@mail.rsts.org> <47B49A16.1080103@FreeBSD.org> <20080214131026.Y75492@mail.rsts.org> <200802151440.m1FEeGVr084431@lava.sentex.ca> <20080215085714.K79197@mail.rsts.org> <47B5F7BF.9050608@FreeBSD.org> <20080219145105.C96725@mail.rsts.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Brett Bump wrote:
> Oops!
> 
> ../../../ufs/ufs/ufs_quota.c: In function `chkdq':
> ../../../ufs/ufs/ufs_quota.c:168: error: `do_check' undeclared (first use in this function)
> ../../../ufs/ufs/ufs_quota.c:168: error: (Each undeclared identifier is reported only once
> ../../../ufs/ufs/ufs_quota.c:168: error: for each function it appears in.)
> ../../../ufs/ufs/ufs_quota.c:174: error: `warn' undeclared (first use in this function)
> ../../../ufs/ufs/ufs_quota.c:178: error: too many arguments to function `chkdqchg'
> ../../../ufs/ufs/ufs_quota.c: In function `chkdqchg':
> ../../../ufs/ufs/ufs_quota.c:230: error: number of arguments doesn't match prototype
> ../../../ufs/ufs/ufs_quota.c:75: error: prototype declaration
> ../../../ufs/ufs/ufs_quota.c: In function `chkiq':
> ../../../ufs/ufs/ufs_quota.c:330: error: too many arguments to function `chkiqchg'
> ../../../ufs/ufs/ufs_quota.c: In function `chkiqchg':
> ../../../ufs/ufs/ufs_quota.c:412: error: `warn' undeclared (first use in this function)
> ../../../ufs/ufs/ufs_quota.c: In function `quotaon':
> ../../../ufs/ufs/ufs_quota.c:522: warning: implicit declaration of function `quotaoff1'
> ../../../ufs/ufs/ufs_quota.c:522: warning: nested extern declaration of `quotaoff1'
> ../../../ufs/ufs/ufs_quota.c:583: warning: implicit declaration of function `quotaoff_inchange'
> ../../../ufs/ufs/ufs_quota.c:583: warning: nested extern declaration of `quotaoff_inchange'
> ../../../ufs/ufs/ufs_quota.c: At top level:
> ../../../ufs/ufs/ufs_quota.c:599: warning: function declaration isn't a prototype
> ../../../ufs/ufs/ufs_quota.c:599: warning: static declaration of 'quotaoff1' follows non-static declaration
> ../../../ufs/ufs/ufs_quota.c:522: warning: previous implicit declaration of 'quotaoff1' was here
> ../../../ufs/ufs/ufs_quota.c:680: warning: function declaration isn't a prototype
> ../../../ufs/ufs/ufs_quota.c: In function `dqget':
> ../../../ufs/ufs/ufs_quota.c:1130: error: `vfslocked' undeclared (first use in this function)
> ../../../ufs/ufs/ufs_quota.c:1134: error: `dqvplocked' undeclared (first use in this function)
> ../../../ufs/ufs/ufs_quota.c:1054: warning: unused variable `td'
> ../../../ufs/ufs/ufs_quota.c: At top level:
> ../../../ufs/ufs/ufs_quota.c:1022: warning: 'dqhashfind' defined but not used
> *** Error code 1
> 
> This was after applying the patch and disabling quotas.

If you can just disable quotas you don't need the mpsafe quota patch :)

I guess the patch has become stale in the time since it was created. 
There were other changes committed to the 6.x quota support in recent 
months, so they probably invalidated it.

Kris




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47BB53A5.30100>