Date: Thu, 16 Aug 2018 11:07:02 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Koichiro Iwao <meta@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r477306 - in head: audio audio/pulseaudio-module-xrdp net/xrdp Message-ID: <20180816090702.ahk7s6da4e4sxqve@atuin.in.mat.cc> In-Reply-To: <201808160151.w7G1p4A9025211@repo.freebsd.org> References: <201808160151.w7G1p4A9025211@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--mhq6zpj3xysynirp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 16, 2018 at 01:51:04AM +0000, Koichiro Iwao wrote: > +PORTNAME=3D pulseaudio-module-xrdp > +PORTVERSION=3D 0.0.20180808 This is not the way to handle software that do not define versions. Please read this to learn how to handle this in the future: https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.ht= ml#makefile-master_sites-github-ex4 > +CATEGORIES=3D audio > + > +MAINTAINER=3D meta@FreeBSD.org > +COMMENT=3D PulseAudio module which enables xrdp to use audio redirection > + > +LICENSE=3D APACHE20 > + > +BUILD_DEPENDS=3D ${NONEXISTENT}:audio/pulseaudio:configure \ > + ${LOCALBASE}/include/xrdp_constants.h:net/xrdp > +LIB_DEPENDS=3D libpulse.so:audio/pulseaudio > + > +USES=3D autoreconf:build libtool pkgconfig > +GNU_CONFIGURE=3D yes > +USE_GITHUB=3D yes > +GH_ACCOUNT=3D neutrinolabs > +GH_PROJECT=3D pulseaudio-module-xrdp Default, remove. > +GH_TAGNAME=3D 0d80384 > + > +PLIST_FILES=3D `${PULSE_MODDIR}`/module-xrdp-sink.so \ > + `${PULSE_MODDIR}`/module-xrdp-source.so The ` seem very strange here and only work because of the current implementation details of PLIST_FILES. Please find another way to handle this. --=20 Mathieu Arnold --mhq6zpj3xysynirp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlt1PrVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkiWrQ//a7G350bhZ5xgpl52+NrVaKjtb/oegq/IsHVifTARuShKn5WwbARMfsv2 7qvxiRWJQOcr6ZnS+9SIYAmn1VQEIFO5CqTGsJOp2zgLaA1v330oxJbp7l9681rx zAsWTEydDQoU4cgBIxCtxKLZEmCuj4oejfvrZiq27HqzrJw+b275yJFVH3Wyn++D SskIq4p2m6zB0nWlrrj+OjxfbWujyEahfc883h1UOvSxtQmivNS1NOOwH0nQrjmv OrjMrfvm/oIUb2h/mPJG+rj4nTT70NZDjxG+8YE+oFJru2b9OlYId3SVonzXgf6h 9h5ruYyeRaucaFpMMNec4Dr53mXQW92jk99E8+VNxV0K/+6VoGrvUdbhOcfkG85U pWoC52xdTr8cM/BQefyVw7B8kXlfaM5vzCZNI5tzCECcvVjV6ocsObaJ7eJ/hUYl zT97SDzOnL4HtBWSF/hYZgkRz0IasTQNjS4y9QObpH3EJ4jnGIGBa4MrnU4uqHlD GFiMGOjtV1STu78LW1B5DSJto1gUPXLgSIvRrVhqrqhYlMkBcRn5hrUV2Toz0Yoy Em2oz+v45S6JzeI/dyKpPTdRaO9rTN2d9tqXkl86Dmb6PKbc2c24Bd3Z8KBwFi30 Vg1bDEgPQ2HMi2rhx/7KEx/vChB7w0PYOE5+zLt9XEz85fkdnDM= =Hd/b -----END PGP SIGNATURE----- --mhq6zpj3xysynirp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180816090702.ahk7s6da4e4sxqve>