From owner-p4-projects@FreeBSD.ORG  Tue Apr 26 11:45:18 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B84E816A4D0; Tue, 26 Apr 2005 11:45:17 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 833CD16A4CE
	for <perforce@FreeBSD.org>; Tue, 26 Apr 2005 11:45:17 +0000 (GMT)
Received: from mail23.sea5.speakeasy.net (mail23.sea5.speakeasy.net
	[69.17.117.25])	by mx1.FreeBSD.org (Postfix) with ESMTP id 3389043D5E
	for <perforce@FreeBSD.org>; Tue, 26 Apr 2005 11:45:17 +0000 (GMT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 12320 invoked from network); 26 Apr 2005 11:45:17 -0000
Received: from server.baldwin.cx ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)AES256-SHA encrypted SMTP
	for <davidxu@FreeBSD.org>; 26 Apr 2005 11:45:15 -0000
Received: from [192.168.0.15] (osx.baldwin.cx [192.168.0.15])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j3QBj1Tn031778;
	Tue, 26 Apr 2005 07:45:01 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
In-Reply-To: <200504171042.j3HAgeTQ054345@repoman.freebsd.org>
References: <200504171042.j3HAgeTQ054345@repoman.freebsd.org>
Mime-Version: 1.0 (Apple Message framework v622)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <87f1dd37c46f5e61c68035b9989ae5b7@FreeBSD.org>
Content-Transfer-Encoding: 7bit
From: John Baldwin <jhb@FreeBSD.org>
Date: Tue, 26 Apr 2005 07:45:01 -0400
To: David Xu <davidxu@FreeBSD.org>
X-Mailer: Apple Mail (2.622)
X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed 
	version=3.0.2
X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx
cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 75366 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2005 11:45:18 -0000


On Apr 17, 2005, at 6:42 AM, David Xu wrote:

> http://perforce.freebsd.org/chv.cgi?CH=75366
>
> Change 75366 by davidxu@davidxu_alona on 2005/04/17 10:42:05
>
> 	Implement cpu_set_user_tls for sparc64.
>
> Affected files ...
>
> .. 
> //depot/projects/davidxu_thread/src/sys/sparc64/sparc64/vm_machdep.c#6 
> edit
>
> Differences ...
>
> ==== 
> //depot/projects/davidxu_thread/src/sys/sparc64/sparc64/vm_machdep.c#6 
> (text+ko) ====
>
> @@ -194,6 +194,15 @@
>  	td->td_retval[1] = tf->tf_out[1];
>  }
>
> +void
> +cpu_set_user_tls(struct thread *td, void *tls_base, size_t tls_size,
> +        int tls_seg __unused)
> +{
> +	if (td == curthread)
> +		flushw();
> +	td->td_frame->tf_global[7] = tls_base;
> +}
> +

I think for at least this one and Alpha you might want a critical 
section in the curthread case like you do on i386 and amd64 since 
calling the Alpha PAL and setting tls_base + flushw() are more than one 
instruction long.

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org