From owner-svn-src-all@freebsd.org Thu Feb 23 17:13:16 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2208FCEBBD8; Thu, 23 Feb 2017 17:13:16 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-ot0-x22b.google.com (mail-ot0-x22b.google.com [IPv6:2607:f8b0:4003:c0f::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DB079E6B; Thu, 23 Feb 2017 17:13:15 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-ot0-x22b.google.com with SMTP id j38so28248018otb.3; Thu, 23 Feb 2017 09:13:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ldbpWJ1k6b/YaY64ZDQvJTtldeGbLIIn1YU3618kPYg=; b=OOuHlvlHBadL9Yr2xbcu13gXWjILP+hoYNt3kLYTNPrXETy04JrS33Xo+tWzrym7qi QaT3Dbm1AP+iauAQplir/xd3D5SqXdnErhoH40XcLQjhrXZN17NPT60Js6cwlkb5W7X/ 9jitaAEvG9azVfxEiRSr1MxRCNEWgp8+s9DGMd+FlBO9dPV5HfQi708oAKLWCH6QrHFF BUsl0h4w71b68LiBjpkZHrC/cy3CA84pIjaN57LKRaBBe50VFiE5Z+AVhO4w32+OeW2Q tzHI3sz3zjuO7yBZKJZAzuzkX+grXgb8ykgLPNsMiLA8hYu5AG58b6nw8e21sJLBqDoH BpaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ldbpWJ1k6b/YaY64ZDQvJTtldeGbLIIn1YU3618kPYg=; b=t6Xj1q+rmo7rVchMJdb0C0H/BP5rLUsrti7i2SvV9mqZSG7Eqt5+YvvP31zkDx22Jf LSBJJnMmFecMwC+2a+Y3NkgMJv9c9naX/lU+UwtfFa9QwvIyKz4UK0vfSDgze5wjU3JS AWvfuly9+XxKlhHf/rR7JyGcBPZqOxrwibSE920LB2AbisB2PQQdiy4dfXUwJSdzmGxo Y3cg3SblDAJptuZ6t2rIv7bQfX6JwlS/dGl+29lB2BPJS8eohEywWe2C4IuRlUordUb8 LW/1cGTe7F8KG7ZWA5+Og98uAvQqWqvE6VrPefCgQdL5yPcMGIIBaPM8sCIxNE8KwBg3 c8yw== X-Gm-Message-State: AMke39ldRKwKEjqJfLaKSVaa+044krENDmW4HY4BjWQjyFWcjznAmtaehyIBc7Cgt1JmDt545B3nyCiQQX8I5w== X-Received: by 10.157.37.26 with SMTP id k26mr18849583otb.149.1487869995096; Thu, 23 Feb 2017 09:13:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.88.138 with HTTP; Thu, 23 Feb 2017 09:13:14 -0800 (PST) In-Reply-To: <201702231530.v1NFULwx024028@repo.freebsd.org> References: <201702231530.v1NFULwx024028@repo.freebsd.org> From: Benjamin Kaduk Date: Thu, 23 Feb 2017 11:13:14 -0600 Message-ID: Subject: Re: svn commit: r314142 - head/sys/dev/ce To: "Pedro F. Giffuni" Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 17:13:16 -0000 On Thu, Feb 23, 2017 at 9:30 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Thu Feb 23 15:30:21 2017 > New Revision: 314142 > URL: https://svnweb.freebsd.org/changeset/base/314142 > > Log: > dev/ce: double assignment. > > The code is not operational right now so just comment away an obviously > useless assignment. Fix some typos while here. > > Found with: coccinelle (da.cocci) > > Modified: > head/sys/dev/ce/ceddk.c > > Modified: head/sys/dev/ce/ceddk.c > ============================================================ > ================== > --- head/sys/dev/ce/ceddk.c Thu Feb 23 15:10:46 2017 (r314141) > +++ head/sys/dev/ce/ceddk.c Thu Feb 23 15:30:21 2017 (r314142) > @@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c) > "UserRequest (%s:%d)\n", __FUNCTION__, > __LINE__)); > return; > } > - req->Command = TAU32_Configure_Commit | > - TAU32_Tx_Stop | TAU32_Rx_Stop; > +// req->Command = TAU32_Configure_Commit | > +// TAU32_Tx_Stop | TAU32_Rx_Stop; > Should probably stick to C-style comments, though. -Ben