From owner-freebsd-arch Wed Jan 30 13: 6:43 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id B008E37B404 for ; Wed, 30 Jan 2002 13:06:37 -0800 (PST) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id g0UL6IJ115910; Wed, 30 Jan 2002 16:06:18 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20020130112600.I13686@elvis.mu.org> References: <3C57C858.5FCC9453@mindspring.com> <21755.1012385956@critter.freebsd.dk> <20020130112600.I13686@elvis.mu.org> Date: Wed, 30 Jan 2002 16:06:17 -0500 To: Alfred Perlstein , Poul-Henning Kamp From: Garance A Drosihn Subject: Re: __P macro question Cc: Terry Lambert , Jordan Hubbard , Dallas De Atley , arch@FreeBSD.ORG Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 11:26 AM -0800 1/30/02, Alfred Perlstein wrote: >Removing the __P causes these specific problems: > >1) repo bloat. In the past, we have generated "repo-bloat" just to remove unneeded blanks at the end of lines. If we survived it for that, we can survive it for removing __P()'s. We're constantly doing style fixes which "bloat" the repo. >2) incompatible deltas with other BSDs and older versions of BSD. Note that this is less true than it used to be. For instance, a recent contribution sent to freebsd-standards said: This patch adds the -b and -s options to 'fold'. It's mostly taken from NetBSD but I've hopefully kept it compile-able by K&R compilers. In other words, here's someone who is taking code *from* NetBSD, and *adding* __P()'s to it. Why does he have to add them? Because more than 16 months ago, NetBSD applied an update to 'fold' where the commit message was: (and I quote) Un-__P and ANSIfy. So, while it used to be that there was an advantage in keeping __P()'s so we would remain the same as some other BSD, we now have some new developers who think they should *add* __P()'s to become *incompatible* with another BSD. Clearly we're sending the wrong signal to people who are trying to contribute to FreeBSD. Time has moved on. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message