Date: Fri, 13 Jan 2006 04:31:40 +0900 (JST) From: NIIMI Satoshi <sa2c@sa2c.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/91721: mail/postfix: "etc/rc.d/postfix.sh restart" may fail Message-ID: <20060112193140.22E3B11456@berkeley.l.sa2c.net> Resent-Message-ID: <200601121940.k0CJe66B020339@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 91721
>Category: ports
>Synopsis: mail/postfix: "etc/rc.d/postfix.sh restart" may fail
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Jan 12 19:40:05 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: NIIMI Satoshi
>Release: FreeBSD 6.0-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD berkeley.l.sa2c.net 6.0-RELEASE-p2 FreeBSD 6.0-RELEASE-p2 #1: Wed Jan 11 18:32:57 JST 2006 root@berkeley.l.sa2c.net:/usr/obj/usr/src/sys/GENERIC i386
>Description:
Running "${PREFIX}/etc/rc.d/postfix.sh restart" may produce an error
postfix/postfix-script: fatal: the Postfix mail system is already running
if "postfix stop" takes some time. It is because the postfix(8)
command just sends a signal to the master(8) daemon and does not wait
the process to be stopped.
The PID file should be checked to restart the daemon reliably.
>How-To-Repeat:
>Fix:
--- postfix.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/mail/postfix/Makefile,v
retrieving revision 1.105
diff -u -r1.105 Makefile
--- Makefile 12 Jan 2006 16:23:59 -0000 1.105
+++ Makefile 12 Jan 2006 19:17:27 -0000
@@ -16,7 +16,7 @@
PORTNAME= postfix
PORTVERSION= 2.2.8
-PORTREVISION= 1
+PORTREVISION= 2
PORTEPOCH= 1
CATEGORIES= mail ipv6
MASTER_SITES= ftp://ftp.porcupine.org/mirrors/postfix-release/official/ \
Index: files/postfix.sh.in
===================================================================
RCS file: /home/ncvs/ports/mail/postfix/files/postfix.sh.in,v
retrieving revision 1.1
diff -u -r1.1 postfix.sh.in
--- files/postfix.sh.in 12 Jan 2006 16:23:59 -0000 1.1
+++ files/postfix.sh.in 12 Jan 2006 19:15:46 -0000
@@ -14,6 +14,8 @@
# DO NOT CHANGE THESE DEFAULT VALUES HERE
#
postfix_enable="${postfix_enable-NO}"
+postfix_pidfile="${postfix_pidfile:-/var/spool/postfix/pid/master.pid}"
+postfix_procname="${postfix_procname:-/usr/local/libexec/postfix/master}"
. %%RC_SUBR%%
@@ -23,6 +25,9 @@
start_cmd=${name}_start
stop_cmd=${name}_stop
+pidfile=${postfix_pidfile}
+procname=${postfix_procname}
+
postfix_start() {
%%PREFIX%%/sbin/postfix start
}
--- postfix.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060112193140.22E3B11456>