Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Jul 2012 11:32:34 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Max Khon <fjoe@freebsd.org>
Cc:        svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   Re: svn commit: r238775 - stable/8/sys/dev/puc
Message-ID:  <201207301132.34524.jhb@freebsd.org>
In-Reply-To: <201207251742.q6PHgvDj083177@svn.freebsd.org>
References:  <201207251742.q6PHgvDj083177@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, July 25, 2012 1:42:57 pm Max Khon wrote:
> Author: fjoe
> Date: Wed Jul 25 17:42:57 2012
> New Revision: 238775
> URL: http://svn.freebsd.org/changeset/base/238775
> 
> Log:
>   MFC: r227457, r237350, r237357
>   
>   Add support for the following Moxa PCIe multiport serial boards:
>   - CP102E
>   - CP102EL
>   - CP104EL-A
>   - CP104JU
>   - CP114EL
>   - CP118EL-A
>   - CP168EL-A

You ignored the comments from Marcel when you committed this to HEAD it seems.  
You need to revert d_ofs back to a int8_t and add a config_function for these 
adapters instead that use an offset of 0x200.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201207301132.34524.jhb>