From owner-svn-ports-all@freebsd.org  Sun Dec 24 14:27:42 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB68CE92151;
 Sun, 24 Dec 2017 14:27:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 88B3E7C9E1;
 Sun, 24 Dec 2017 14:27:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id CF69D3F27; Sun, 24 Dec 2017 14:27:41 +0000 (UTC)
Date: Sun, 24 Dec 2017 14:27:41 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: "Vanilla I. Shu" <vanilla@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r457016 - in head/net: . libstorj
Message-ID: <20171224142741.GE1693@FreeBSD.org>
References: <201712230216.vBN2GwKF073752@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201712230216.vBN2GwKF073752@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Dec 2017 14:27:42 -0000

On Sat, Dec 23, 2017 at 02:16:58AM +0000, Vanilla I. Shu wrote:
> New Revision: 457016
> URL: https://svnweb.freebsd.org/changeset/ports/457016
> 
> Log:
>   Add libstorj 1.0.2, c library and CLI for encrypted file transfer on the
>   Storj network.
>   
>   PR:		224523
>   Submitted by:	jhixson@gmail.com
> 
> Added: head/net/libstorj/Makefile
> ...
> @@ -0,0 +1,30 @@
> +USES=		autoreconf gmake libtool localbase pkgconfig
> +
> +GNU_CONFIGURE=	yes
> +USE_LDCONFIG=	yes
> +
> +#CFLAGS+=	-I. -I${LOCALBASE}/include
> +#LDFLAGS+=	-L. -L${LOCALBASE}/lib

These two lines should've probably been removed before committing.

> Added: head/net/libstorj/pkg-descr
> ...
> @@ -0,0 +1,3 @@
> +C library for encrypted file transfer on the Storj network
> +
> +WWW: https://github.com/Storj/libstorj

Port description should not simply rephrase or copy COMMENT, see Section
3.2.1 of the PHB.  It should also be terminated with a full stop (dot).

./danfe