From nobody Wed Apr 22 21:23:46 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g1C004Wk8z6bMX8 for ; Wed, 22 Apr 2026 21:24:00 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g1Bzz678Bz3K5n for ; Wed, 22 Apr 2026 21:23:59 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso49647915e9.3 for ; Wed, 22 Apr 2026 14:23:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776893038; x=1777497838; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NAHU7ZAClR6vVePvn714kI30fp/QY/nPZiXESxfOhtU=; b=PhAsWlAuhDqkbz1+9/nnMnoNpNpj+oUgVUdWxs//YvY6djpAEOanp4PvrGWHIe9SUO Dyt4Gq3kAR95Tm1oqFJcioDfPk+Y9CgeuZtxo94o6WSINjyXD3PeYpwlOQKKSVC+7Run OWuWtmSsTNrYXU3JrCB/e23onn7EjB6CHKb0eekuyREzY5YDiL1SXy1qTC3bdhrvHUwo lZx0EJw+4sZQzs3UXIJP3CpfAuxlyssYefJyKjBv1SOeE2ot4nh64dxQY1PXq7iCigtN 3vKWx0SQvBMm42Y06apBpflCQEji/NVTXj752wiyTJ+20M3XG/fuBMO9Iak29G+W07fJ EE7Q== X-Forwarded-Encrypted: i=1; AFNElJ9aCWbFUptZ8GCcsamLnqr9JhCPqn0lAkzrQ3Leo1xB+pG6UVA05cNb8SD0ltK/ReUB3JV2U1J9ln0OfbCxhYpqS87s@freebsd.org X-Gm-Message-State: AOJu0YzyBizsT2MUbbf2YnrHSLDSXVZ54C16TsImyH65hYxcJGe5/5Ru OtN5HaoRWCgushoR+eEvHjX0dO+UMDJWpq7GAIjMT49rozNcJZN3xkc6ffLVkUtGHIY= X-Gm-Gg: AeBDiesdYRs9Vyf4CgJE83/wcZsTWoKznIR5d7MskFOg3BpfNjyC5h0rT2Zc8u6iNd+ UcN5rW23ihoocp6od6JP5f3gdU6By3LiFS1UAQWt2ABXGOP/rLT9q8MHfj27M3ClwmhPu51/0A/ p7uTeOtSFeX03pIL75JKLAJvpmoLszARFlJ9pmgnVOk7KLcfh/prmTP3M1OhP+o9jaBFiiDu4Rq oYkP1+jlGTvNUY+kONQsO2tbpolqF5KVZLKaDLTKndy/LobjudKYYAjbTSeZcua4n+qHh/HCgFW Bo5BnxTYpnwc55l8yI6gxCcL5xXI0LYa+LYpxMWh1mHsGlTjwhu2OOX06fevnRX0wx2wvCRHqHl W3tzJLDflSxdedJ/HVDSnNYdHINcyOZ6JaQ7LaUwPt6Vx/MegjMU8+4GGCxG+KWxdADI38IHhTS ObN11BxvCXY5rKfMRw3/0wg2wMUOtOBvkKV1jkLKFlNU+e6lkZyqnZ5+ixp3iDswsZ7TWz2ovab 5HCfA== X-Received: by 2002:a05:600c:4e14:b0:489:1f08:91b with SMTP id 5b1f17b1804b1-4891f080a7emr204832655e9.16.1776893037980; Wed, 22 Apr 2026 14:23:57 -0700 (PDT) Received: from smtpclient.apple (nat-184-78.net.cam.ac.uk. [131.111.184.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4d112sm52616177f8f.29.2026.04.22.14.23.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Apr 2026 14:23:56 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: git: f3bd86ba1851 - main - freebsd-version(1): Disable pathname expansion in -j option From: Jessica Clarke In-Reply-To: <69e92839.21955.4a101d64@gitrepo.freebsd.org> Date: Wed, 22 Apr 2026 22:23:46 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Nami Arjmandi Content-Transfer-Encoding: quoted-printable Message-Id: <94D02914-6908-4954-9826-5AF756D3352F@freebsd.org> References: <69e92839.21955.4a101d64@gitrepo.freebsd.org> To: Pouria Mousavizadeh Tehrani X-Mailer: Apple Mail (2.3864.400.21) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4g1Bzz678Bz3K5n X-Spamd-Bar: ---- On 22 Apr 2026, at 20:57, Pouria Mousavizadeh Tehrani = wrote: >=20 > The branch main has been updated by pouria: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Df3bd86ba18512aca7099af2d2d49da5e= 46708d17 >=20 > commit f3bd86ba18512aca7099af2d2d49da5e46708d17 > Author: Nami Arjmandi > AuthorDate: 2026-04-22 16:23:22 +0000 > Commit: Pouria Mousavizadeh Tehrani > CommitDate: 2026-04-22 19:55:19 +0000 >=20 > freebsd-version(1): Disable pathname expansion in -j option >=20 > Set the -f flag to sh(1) to disable pathname expansion. > Also, quote the jail variable to ensure correct behavior when = passed > to jexec(8). >=20 > Signed-off-by: Nami Arjmandi > Reviewed by: pouria > Pull-Request: https://github.com/freebsd/freebsd-src/pull/2158 > --- > bin/freebsd-version/freebsd-version.sh.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/bin/freebsd-version/freebsd-version.sh.in = b/bin/freebsd-version/freebsd-version.sh.in > index 157294dfa582..42b555ccafd9 100644 > --- a/bin/freebsd-version/freebsd-version.sh.in > +++ b/bin/freebsd-version/freebsd-version.sh.in > @@ -26,7 +26,7 @@ > # > # >=20 > -set -e > +set -ef This is a big hammer that could lead to quite surprising results. Is there a reason we don=E2=80=99t just quote things appropriately? Or at = least limit the scope of set -f to be only around specific places. Jessica > USERLAND_VERSION=3D"@@REVISION@@-@@BRANCH@@" >=20 > @@ -88,7 +88,7 @@ userland_version() { > # > jail_version() { > for i in $jail; do > - jexec -- $i freebsd-version > + jexec -- "$i" freebsd-version > done > } >=20 >=20