From owner-freebsd-chat Sun Nov 24 13:16:28 2002 Delivered-To: freebsd-chat@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7172537B401 for ; Sun, 24 Nov 2002 13:16:27 -0800 (PST) Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4A1A043E9C for ; Sun, 24 Nov 2002 13:16:26 -0800 (PST) (envelope-from keramida@freebsd.org) Received: from gothmog.gr (patr530-b106.otenet.gr [195.167.121.234]) by mailsrv.otenet.gr (8.12.6/8.12.6) with ESMTP id gAOLG2Yh001833; Sun, 24 Nov 2002 23:16:15 +0200 (EET) Received: from gothmog.gr (gothmog [127.0.0.1]) by gothmog.gr (8.12.6/8.12.6) with ESMTP id gAOLFvLP002475; Sun, 24 Nov 2002 23:15:57 +0200 (EET) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by gothmog.gr (8.12.6/8.12.6/Submit) id gAOLFvHi002474; Sun, 24 Nov 2002 23:15:57 +0200 (EET) (envelope-from keramida@freebsd.org) Date: Sun, 24 Nov 2002 23:15:57 +0200 From: Giorgos Keramidas To: Brad Knowles Cc: Cliff Sarginson , freebsd-chat@freebsd.org Subject: Re: Style(9) question Message-ID: <20021124211557.GB1145@gothmog.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: owner-freebsd-chat@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org In-Reply-To: On 2002-11-24 21:12, Brad Knowles wrote: > At 6:27 PM +0200 2002/11/24, Giorgos Keramidas wrote: > > Not really "rejected", but if you troll the PR database for a while, > > you will notice followups to the spirit of ``This looks fine, but it > > doesn't fit the style of the affected sources. Can you please fix > > this, and post the new patch in a followup?'' > > And how many times has a modified patch been submitted as a > follow-up, versus how many times people didn't bother to ever again > file a PR? I haven't really looked, but if one were to do a ``human resources'' type of research, you'd also have to include cases where a committer makes changes to the submitted patches (and separate these in two cases too, depending on whether the original submitter was annoyed or not). That's a bit difficult to do though, since a lot of the people who are annoyed by such changes probably don't bother mailingn gnats about it... I always try to be as gentle as I can, when I need to make changes to submitted patches, and I can only hope that it doesn't make anyone too upset, leading them to stop working with FreeBSD. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-chat" in the body of the message