From nobody Mon Jan 3 03:46:24 2022 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 41FCE192BCA2 for ; Mon, 3 Jan 2022 03:46:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JS1rK0Dcfz3Lf1 for ; Mon, 3 Jan 2022 03:46:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id CD2361E461 for ; Mon, 3 Jan 2022 03:46:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2033kOfK052044 for ; Mon, 3 Jan 2022 03:46:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2033kOuw052043 for fs@FreeBSD.org; Mon, 3 Jan 2022 03:46:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 251342] fs/unionfs: VOP_UNSET_TEXT without VOP_SET_TEXT leads to panic Date: Mon, 03 Jan 2022 03:46:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641181585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JYyP0pqvqHDPxqbCVyiA6HNcBa6zdEj+z5YnSm44v+c=; b=HzhRdJUCKlz/xUVDyQNmHc0quzg1VKpvwA2MLOQAkV58MwCtL/HVS792tOgVzbe0NrMobv 6ZR6PbpV5M0eLZ35HeKrQoMhEssAvUAHe9EdvgfSS71nJ10/ghB5PmTa6nCH3XtDFsucnu R4EaiKMFIT4tm0Mj93cXWfZ4lLZqfjaDTr8GIlLArS3ApXnjTbB1RwXdIAdGrg4tQqwKTS hxH0Z4lz5ZUJburN2Nu8hP/wUmEnMisCTfrm72/71+eV/2+UW9H6j0o2/oUEnIlwG7HsHR T5z+Y9XmRlX1zG0ELa6NxwKLhMG4uD7v42NoTOnf0Z5bKq3ZKyVWY8RgXKq5iw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641181585; a=rsa-sha256; cv=none; b=aNwE+H7EF/x3FNpiIDW3Ns3Tdglw+QilztG267XKEcpI+Ro7NJ1v9lCvBtFvUexypvb8Fi m7kjs1gzN7bMMwTrcpLXgIhka4AMft3Wb4uyUj96zJlBoatmDEu7e4ReQQxAnFa8B3JZGL rc/wHxtbCpn0JER6Jcj63Ojx9bNm/AKcqfSCfrreTko7PXA6Tg5Mwc7D75YCbTHIYPqi4X Kt1F4Gwj/dycJrD7w1ZyxEiIis/L1rj+QhOKjdL0+o+gIoHMm3waHiOzALOxAj1qZDRFRD eSVsRzonIpwT3euQ9n6xgN6Owc1QtpGt9EQF4UzNPQEPF2EQ+H2xqZdwIue/bg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251342 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D9e891d43f586e91541bd61fb12550de29= 6d76fd9 commit 9e891d43f586e91541bd61fb12550de296d76fd9 Author: Jason A. Harmening AuthorDate: 2021-12-21 23:51:51 +0000 Commit: Jason A. Harmening CommitDate: 2022-01-03 03:52:58 +0000 unionfs: implement VOP_SET_TEXT/VOP_UNSET_TEXT The implementation simply passes the text ref to the appropriate underlying vnode. Without this, the default [un]set_text implementation will only manage the text ref on the unionfs vnode, causing it to be out of sync with the underlying filesystems and potentially allowing corruption of executable file contents. On INVARIANTS kernels, it also readily produces a panic on process termination because the VM object representing the executable mapping is backed by the underlying vnode, not the unionfs vnode. PR: 251342 Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D33611 sys/fs/unionfs/union_vnops.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=