From owner-cvs-all  Mon Feb 25  1:50: 9 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id EA8B037B405; Mon, 25 Feb 2002 01:49:55 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id UAA04823;
	Mon, 25 Feb 2002 20:49:51 +1100
Date: Mon, 25 Feb 2002 20:50:12 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: <markm@FreeBSD.org>
Cc: Bruce Evans <bde@FreeBSD.org>, <cvs-committers@FreeBSD.org>,
	<cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/usr.bin/mail aux.c 
In-Reply-To: <200202250904.g1P94Kax011449@grimreaper.grondar.org>
Message-ID: <20020225204722.F40272-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 25 Feb 2002 markm@FreeBSD.org wrote:

> > bde         2002/02/24 21:16:22 PST
> >
> >   Modified files:
> >     usr.bin/mail         aux.c
> >   Log:
> >   #include <sys/time.h> instead of depending on namespace pollution in
> >   <sys/stat.h> for the declaration of struct timeval.  Intentionally
> >   don't follow the local style of polluting the local headers.
>
> Surely we should be (also) fixing this namespace pollution?

It (#include half of /usr/include in a local header and include the local
header in *.c) is only a style bug when it is local, and there are a few
million other style bugs to fix first.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message