From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Oct 6 02:20:05 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AFE38106564A for ; Sat, 6 Oct 2012 02:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 672418FC0A for ; Sat, 6 Oct 2012 02:20:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q962K5w2051951 for ; Sat, 6 Oct 2012 02:20:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q962K5BY051949; Sat, 6 Oct 2012 02:20:05 GMT (envelope-from gnats) Resent-Date: Sat, 6 Oct 2012 02:20:05 GMT Resent-Message-Id: <201210060220.q962K5BY051949@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Michael Curtis Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5D5CB106564A for ; Sat, 6 Oct 2012 02:12:35 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 480E58FC08 for ; Sat, 6 Oct 2012 02:12:35 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q962CYqi056730 for ; Sat, 6 Oct 2012 02:12:34 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id q962CY8p056729; Sat, 6 Oct 2012 02:12:34 GMT (envelope-from nobody) Message-Id: <201210060212.q962CY8p056729@red.freebsd.org> Date: Sat, 6 Oct 2012 02:12:34 GMT From: Michael Curtis To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/172377: Fix for p5-Image-Scale (fails to load with png-1.5.x) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2012 02:20:05 -0000 >Number: 172377 >Category: ports >Synopsis: Fix for p5-Image-Scale (fails to load with png-1.5.x) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Oct 06 02:20:05 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Michael Curtis >Release: 9.0 >Organization: >Environment: FreeBSD citadel 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: p5-Image-Scale uses png_memcpy, which is now a private API in PNG and not exposed to external clients. This causes a compile warning and the .so fails to load when Perl tries to load it, due to an unresolved symbol. >How-To-Repeat: Compile p5-Image-Scale against a recent libpng, load the module in Perl. >Fix: The attached patch (to be placed in files dir of port) changes the png_memcpy to an ordinary memcpy. This appears to be safe, and png_memcpy is #define'd to memcpy inside libpng these days. Patch attached with submission follows: diff -ur work/Image-Scale-0.08/src/png.c work2/Image-Scale-0.08/src/png.c --- src/png.c 2011-07-12 01:03:28.000000000 +1000 +++ src/png.c 2012-10-04 01:53:55.000000000 +1000 @@ -40,7 +40,7 @@ } } - png_memcpy(data, buffer_ptr(im->buf), len); + memcpy(data, buffer_ptr(im->buf), len); buffer_consume(im->buf, len); goto ok; >Release-Note: >Audit-Trail: >Unformatted: