From owner-cvs-all@FreeBSD.ORG Fri Jun 15 17:03:19 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 09FEA16A474 for ; Fri, 15 Jun 2007 17:03:19 +0000 (UTC) (envelope-from infofarmer@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.180]) by mx1.freebsd.org (Postfix) with ESMTP id D577813C4C5 for ; Fri, 15 Jun 2007 17:03:18 +0000 (UTC) (envelope-from infofarmer@gmail.com) Received: by wa-out-1112.google.com with SMTP id j37so1242931waf for ; Fri, 15 Jun 2007 10:03:18 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=uWoB7c1yxDJeS/zuY5Y+Ryd9VnUCzsj+bPmypSNf39j1psj+ZLUYvqPrgAW0o/DLxRwyitY5mqJnh5NqdTGoIWR4gfM2xMxiXvyLJtYglIQxOumqAr1HG/mNiRZXqsSmAT5fqaV5zn7RDOpmkoRjfvTmRLr8yC8lVQxM8GQtb7g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=GyjUmjVlxkZwk8nww5B0Lnk55ZkaxO+fxoDb7zaAtXEZxQ79+IegieIH33gwV195cUsMP5cKYb/5EJi2n4zwRX9Jh2tgTE3hxs/AgKMTOG/7pHrG3EZY7szDiG+9tRAJp95cJtnwaLesyPcK4vsdHevdbAtAO9ZIZ+0/36TCatk= Received: by 10.114.15.1 with SMTP id 1mr3254819wao.1181926998591; Fri, 15 Jun 2007 10:03:18 -0700 (PDT) Received: by 10.114.194.13 with HTTP; Fri, 15 Jun 2007 10:03:18 -0700 (PDT) Message-ID: Date: Fri, 15 Jun 2007 21:03:18 +0400 From: "Andrew Pantyukhin" Sender: infofarmer@gmail.com To: "Li-Wen Hsu" In-Reply-To: <20070615164901.GA86604@FreeBSD.csie.nctu.edu.tw> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200706151428.l5FESrEq080128@repoman.freebsd.org> <20070615142857.64CA516A498@hub.freebsd.org> <20070615164901.GA86604@FreeBSD.csie.nctu.edu.tw> X-Google-Sender-Auth: 5c42448474b74dde Cc: cvs-ports@freebsd.org, YUAN Jue , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/devel/kdesvn Makefile distinfo pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2007 17:03:19 -0000 On 6/15/07, Li-Wen Hsu wrote: > On Fri, Jun 15, 2007 at 19:37:15 +0400, Andrew Pantyukhin wrote: > > > +.if !defined(NOPORTDOCS) > > > +DOCSDIR= ${PREFIX}/share/doc/HTML/en/kdesvn > > > .endif > > > > Is there any merit to this DOCSDIR definition being > > conditional? > > Seems no. Sometimes I put this in the Makefile: > > .if !defined(NOPORTDOCS) > DOCSDIR= /some/other/place > PORTDOCS= * > .endif In spite of what bsd.port.mk says, PORTDOCS can be safely defined even if NOPORTDOCS is defined. Acting on PORTDOCS is conditionalized by this line: .if defined(PORTDOCS) && !defined(NOPORTDOCS) > Besides, though I don't really care where the review goes. (I am very happy > with this) But since some people don't like this. How about replying the > commit in private, and maintaining a "Common Mistakes when Porting" list, > after a number of items collected? Posting it to ports@ list and put into > the porter's handbook might be a good idea. This can get more porters' > attention, and easier to find. Sometimes, looking for something in the > high-traffic mailing list is quite hard. After all, not everyone read > every commit message and its reply, but every should read the handbook > (and read again when it is updated), right? The thing I hope for is that the guys that are so kindly watching me right now will later help us do the very thing you describe - figuring out the most common mistakes and documenting some best practices to avoid them. I'm afraid I won't be able to do it all alone. Moreover, as we've already seen, the pleasant part of the public resonance contributes invaluable opinions to many issues. Thanks!