From owner-svn-ports-all@freebsd.org Wed Sep 14 23:39:19 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 065B2BDA697; Wed, 14 Sep 2016 23:39:19 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id DE19E1047; Wed, 14 Sep 2016 23:39:18 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id D625C16D9; Wed, 14 Sep 2016 23:39:18 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 93BDC23382; Wed, 14 Sep 2016 23:39:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 2OGRTYVtE2hN; Wed, 14 Sep 2016 23:39:15 +0000 (UTC) Subject: Re: svn commit: r422151 - head/devel/php70-APCu DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com B47C123379 To: Guido Falsi , Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201609141913.u8EJD7pP073092@repo.freebsd.org> <1ac065a3-8ddb-0e3b-4d21-d35d726fb63e@FreeBSD.org> Cc: portmgr@FreeBSD.org From: Bryan Drewery Organization: FreeBSD Message-ID: <0f3a866e-505b-1cbf-32d1-b543949841ee@FreeBSD.org> Date: Wed, 14 Sep 2016 16:39:13 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8Xd0w8ka7iLWtw2tjq5hLf62NGAGRLudG" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2016 23:39:19 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8Xd0w8ka7iLWtw2tjq5hLf62NGAGRLudG Content-Type: multipart/mixed; boundary="Onk434q0N4sITDfweVXgVJgsQwifpJoAI"; protected-headers="v1" From: Bryan Drewery To: Guido Falsi , Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Cc: portmgr@FreeBSD.org Message-ID: <0f3a866e-505b-1cbf-32d1-b543949841ee@FreeBSD.org> Subject: Re: svn commit: r422151 - head/devel/php70-APCu References: <201609141913.u8EJD7pP073092@repo.freebsd.org> <1ac065a3-8ddb-0e3b-4d21-d35d726fb63e@FreeBSD.org> In-Reply-To: --Onk434q0N4sITDfweVXgVJgsQwifpJoAI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 9/14/16 4:22 PM, Guido Falsi wrote: > On 09/14/16 21:46, Mathieu Arnold wrote: >> Le 14/09/2016 =C3=A0 21:13, Guido Falsi a =C3=A9crit : >>> Author: madpilot >>> Date: Wed Sep 14 19:13:07 2016 >>> New Revision: 422151 >>> URL: https://svnweb.freebsd.org/changeset/ports/422151 >>> >>> Log: >>> Add PHP_DEFAULT=3D7.0 so that a package is build on the cluster wit= h >>> default ports configuration. >>> =20 >>> PR: 212684 >>> Submitted by: joshruehlig at gmail.com >>> Approved by: Daniel Ylitalo (maintainer) >>> >> >> Please, revert this. >> >> We do not force PHP versions of modules/extensions, either you have th= e >> right default version, and it will build and work, or you don't have t= he >> right default version and it will be a two leg stool. >> >=20 > The reason I did this is there are already other PHP modules doing this= , > so I thought it was ok. >=20 > While I understand what the problem is this is a leaf port and such a > change causes no problems and allows the package to be built in the clu= ster. >=20 > Before reverting this I'd like to have an opinion from portmgr (CCed). >=20 > Meybe some cleaner way to allow php7 parts to be built on the cluster > should be made available, although I don't know what that can be right = now. >=20 It seems reasonable to me since it is NAMED php70-. Setting the default is done in python ports like this as well. Wrapping an IGNORE in !PACKAGE_BUILDING seems ok to me too. --=20 Regards, Bryan Drewery --Onk434q0N4sITDfweVXgVJgsQwifpJoAI-- --8Xd0w8ka7iLWtw2tjq5hLf62NGAGRLudG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJX2d+iAAoJEDXXcbtuRpfP/oUIALz83YfXskbeSLSgm0z/xnrI kWfObBMnba97yeOUwNS/VQ3Hxg2WM5gFHpNEZfZVGno9+9vubqd7pGGajL+pucIK GTI7zS4cdlbqMVCJzj04bsESxSrfZSypzNDNqLuP11DScibd6E/GAoyKXb0tCeEm 6lfDpgBkfXvCP9q3SJ2b30F++4T1bamAOlUm9MAvx+zvvlRcuHApYTR/KG9jr0nu VRNXSQG5Zm9N0R0KSy76n7e6yJqL0kXBFrYR6IkY2q5f5qWDnINQG8LwYdeu8rm6 pph7MDq/8lfXO+7DFVpGyMSpqDc3gPuEe1T84duxZZCLPlZvv6G5RwSNqMahVKw= =M3+w -----END PGP SIGNATURE----- --8Xd0w8ka7iLWtw2tjq5hLf62NGAGRLudG--