From owner-freebsd-current@FreeBSD.ORG Mon Jun 12 20:30:39 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B19EA16A41A; Mon, 12 Jun 2006 20:30:39 +0000 (UTC) (envelope-from vadim_nuclight@mail.ru) Received: from mx27.mail.ru (mx27.mail.ru [194.67.23.63]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD68E43D58; Mon, 12 Jun 2006 20:30:37 +0000 (GMT) (envelope-from vadim_nuclight@mail.ru) Received: from [82.211.136.13] (port=50714 helo=nuclight.avtf.net) by mx27.mail.ru with esmtp id 1Fpt3T-0009DE-00; Tue, 13 Jun 2006 00:30:35 +0400 Date: Tue, 13 Jun 2006 03:30:12 +0700 From: "Vadim Goncharov" To: "Ulrich Spoerlein" References: <70e8236f0606110836j38f7ca33wa3058eaecf386fb5@mail.gmail.com> <20060612185751.GB1226@roadrunner.aventurien.local> Organization: AVTF TPU Hostel Message-ID: In-Reply-To: <20060612185751.GB1226@roadrunner.aventurien.local> User-Agent: Opera M2/7.54 (Win32, build 3865) Content-Type: text/plain; format=flowed; delsp=yes; charset=koi8-r MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: freebsd-isp@freebsd.org, freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: [PATCH] ng_tag - new netgraph node, please test (L7 filtering possibility) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2006 20:30:39 -0000 13.06.06 @ 01:57 Ulrich Spoerlein wrote: > Vadim Goncharov wrote: >> I hope that my explanation was helpful enough to understand :) Also, if >> you will be using >> 7.0, include BPF_JITTER in your kernel config as this will enable >> native code-compiling for >> bpf and ng_bpf - this will speed things up. > > Am I the only one, that thinks BPF_JITTER is a stupid name? It suggest > you add or enable jitter for the packet flow. No one wants jitter! It > sucks. Why isn't it called simply BPF_JIT? Everyone knows what JIT > stands for, JITTER on the other hand is to be avoided. I also think so, but that is not in my competence. But I, after two days of discussion, I must say another thing: WHERE ARE TESTERS ?! You all are wanting this node to be included into FreeBSD src tree, so that it will be available in standard distribution. But before this code should be tested and bugs fixed, if any. And I don't yet see any success stories / bug reports ! >> P.S. Here is quick-and-dirty primer how to convert ipp2p functions to >> ng_bpf(4) input expression for tcpdump(1). [...] >> "get_u32 == __constant_htonl()" means comparing 4-byte values at given >> offset. > > Great stuff, this should make it somewhere into /usr/share/examples! Good idea, but still to be worked for more P2P types examples, and BPF assembly language explanation, as I suspect some things can't be done but tcpdump expressions, though still possible on ng_bpf. Unfortunatelly I do not have much time for this. -- WBR, Vadim Goncharov