From owner-svn-ports-head@freebsd.org  Sat Jul  8 12:48:49 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2EE89D99A6E;
 Sat,  8 Jul 2017 12:48:49 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 10DE27F9FA;
 Sat,  8 Jul 2017 12:48:49 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 6C8BB2912; Sat,  8 Jul 2017 12:48:48 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Matthew Rezny <rezny@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r445016 - in head/x11/libxshmfence: . files
References: <201707041347.v64Dlkx7028953@repo.freebsd.org>
 <2370475.W49dQvnFxO@workstation.reztek>
Date: Sat, 08 Jul 2017 14:48:44 +0200
In-Reply-To: <2370475.W49dQvnFxO@workstation.reztek> (Matthew Rezny's message
 of "Sat, 08 Jul 2017 12:45:57 +0200")
Message-ID: <inj3-8577-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Jul 2017 12:48:49 -0000

Matthew Rezny <rezny@freebsd.org> writes:

>> ++#ifdef HAVE_MKOSTEMP
>> ++			fd = mkostemp(template, O_CLOEXEC);
>> ++#else
>> + 			fd = mkstemp(template);
>> ++#endif
>> + 			if (fd < 0)
>> + 				return fd;
>> + 			unlink(template);
>
> Please explain this unauthorized non-maintainer commit that lacks any PR or 
> review.

In PR 217676 the maintainer explicitly stated they didn't test DRI3 and
disregarded the issue. Maintainers are supposed to upstream changes
to prevent downstream-only bugs like we've seen here.

> Mentioning a closed PR does notyt count. This sort of change really 
> needs to be reviewed by the maintainer(s) before it is committed.

Understood. I'd ask you to not *modify* my patches without approval as well.
Let's not repeat beignet mistakes where upstream understood me better.

> Againb, I must assume this is wholly untested because there has been
> no mention of QA.

QA is mandatory for committers. I did check DRI2 and DRI3 don't work
and don't orphan files.