Date: Sat, 25 Mar 2017 01:36:53 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Diane Bruce <db@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r436813 - head/comms/aldo/files Message-ID: <20170325013653.GB54562@FreeBSD.org> In-Reply-To: <201703241342.v2ODgxmP019211@repo.freebsd.org> References: <201703241342.v2ODgxmP019211@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 24, 2017 at 01:42:59PM +0000, Diane Bruce wrote: > New Revision: 436813 > URL: https://svnweb.freebsd.org/changeset/ports/436813 > > Log: > Fix compile fail under FreeBSD 10.3 No, it does not work this way. You should have explained exactly what was breaking it and exactly how committed changes mitigate/workaround/fix it. > [...] > @@ -0,0 +1,11 @@ > +--- include/Makefile.in.orig 2017-03-24 13:33:28 UTC > ++++ include/Makefile.in > +@@ -101,7 +101,7 @@ PATH_SEPARATOR = @PATH_SEPARATOR@ > + SET_MAKE = @SET_MAKE@ > + SHELL = @SHELL@ > + STRIP = @STRIP@ > +-VERSION = @VERSION@ > ++VERSION = "@VERSION@" I fail to see how is this related to compilation failure on FreeBSD 10.3, as your commit message gave no clue. > @@ -1,5 +1,5 @@ > ---- src/audioworkspace.cc.orig 2007-11-05 03:58:46.000000000 -0500 > -+++ src/audioworkspace.cc 2014-06-08 20:17:26.477449983 -0400 > +--- src/audioworkspace.cc.orig 2007-11-05 08:58:46 UTC > ++++ src/audioworkspace.cc > @@ -31,7 +31,8 @@ > #include <cmath> > #include <iostream> > @@ -10,7 +10,7 @@ > using namespace std; > using namespace libaudiostream; > > -@@ -104,6 +105,7 @@ > +@@ -104,6 +105,7 @@ oastream AudioWorkSpace::create_output_s Please next time either 1) exclude unrelated changes from the commit batch, or 2) properly reflect them in the log. Now anyone who would be blaming this patch has to wonder how these mechanical and seemingly non-functional (or are they? well, commit message gave no clue) are related to compilation failure on FreeBSD 10.3. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170325013653.GB54562>