From owner-freebsd-ports-bugs@FreeBSD.ORG Sat May 29 17:10:54 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB1FB16A4CE for ; Sat, 29 May 2004 17:10:54 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9710F43D48 for ; Sat, 29 May 2004 17:10:54 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i4U0AfBe041823 for ; Sat, 29 May 2004 17:10:41 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i4U0AfgW041822; Sat, 29 May 2004 17:10:41 -0700 (PDT) (envelope-from gnats) Resent-Date: Sat, 29 May 2004 17:10:41 -0700 (PDT) Resent-Message-Id: <200405300010.i4U0AfgW041822@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Oliver Eikemeier Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C6EF16A4CE for ; Sat, 29 May 2004 17:05:00 -0700 (PDT) Received: from fillmore.dyndns.org (port-212-202-49-130.dynamic.qsc.de [212.202.49.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B18E43D2F for ; Sat, 29 May 2004 17:05:00 -0700 (PDT) (envelope-from eikemeier@fillmore-labs.com) Received: from [172.16.0.2] (helo=fillmore-labs.com) by fillmore.dyndns.org with esmtp (Exim 4.34 (FreeBSD)) id 1BUDob-0007nF-W8 for FreeBSD-gnats-submit@FreeBSD.org; Sun, 30 May 2004 02:04:40 +0200 Message-Id: <40B92515.1090000@fillmore-labs.com> Date: Sun, 30 May 2004 02:04:37 +0200 From: Oliver Eikemeier To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/67361: [PATCH] bsd.port.mk: proposal to source out distfile handling to a shell script X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 May 2004 00:10:54 -0000 >Number: 67361 >Category: ports >Synopsis: [PATCH] bsd.port.mk: proposal to source out distfile handling to a shell script >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat May 29 17:10:41 PDT 2004 >Closed-Date: >Last-Modified: >Originator: Oliver Eikemeier >Release: FreeBSD 4.10-STABLE i386 >Organization: Fillmore Labs - http://www.fillmore-labs.com >Environment: System: FreeBSD nuuk.fillmore-labs.com 4.10-STABLE >Description: The distfile handling code in bsd.port.mk is becoming excessively complex. This is a proposal to replace the do-fetch/checksum/makesum/fetch-list targets with a shell script, eliminating more than 1/2k lines of code. The primary focus is to break down bsd.port.mk into components, in order to make refactoring posssible. As a side effect, time critical operations, such as INDEX builds and port surveys should run a little faster, while distfiles handling operations like fetching and extracting are mostly not affected by make(1) running times. >How-To-Repeat: >Fix: A prototype patch and shell script is at This patch integrates and obsoletes: - PR 56641: support for SHA1 and other algorithms in distinfo - PR 62271: calculate size of needed distribution files - PR 63933: support for sorting MASTER_SITES by table lookup - PR 64157: new target check-distfiles While I use this script on my machines without further problems, it could benefit from review and widespread testing on different configurations. -Oliver >Release-Note: >Audit-Trail: >Unformatted: