From owner-freebsd-net@FreeBSD.ORG Tue May 5 12:44:27 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 33F8910F for ; Tue, 5 May 2015 12:44:27 +0000 (UTC) Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C35311D6B for ; Tue, 5 May 2015 12:44:26 +0000 (UTC) Received: by widdi4 with SMTP id di4so159057399wid.0 for ; Tue, 05 May 2015 05:44:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:content-type; bh=K5JCi0e8BiTrHaKjDjvy4MzNbno5Q/GTYsFHXNh5L+k=; b=lx+Se5UvHGTB96SgWbw7zS1/6uhaMCGJiz+qBv1B6Ir+Zhn0as62wlFmKMLTJwEPPG Qn1tuXj//Epkui1t5CwsC21MGKUbj77CzF1K41gt1pXmafZiKvcuujHVVoUZ4kjTi4VN ZNOpeIDaCUds1dkgsIdYiamIBd0TWopFS9ULo7LChufRLgQMQBOhY8LdlPr+B644QFVw 3g1TMjVPMVRVKZzMvcLwtjATxrqHNSxjuO3VgjgdiMLTYuoE9UQbNFlHqdjMd9gy6kZs EU2xySMxuQkiay8LQmC3nZjGixb2pPzlHI8VIxLmRi48Oe4bKfQH0mrWtrDD/HvwqzWS N4IQ== X-Gm-Message-State: ALoCoQnEi9RP87mijMBoEhBMPhCZfm9B0fScjre6+M37L88dm33/5dsr8CZkrpVDfpbbxOGa7G3G X-Received: by 10.194.86.101 with SMTP id o5mr52130446wjz.8.1430829864711; Tue, 05 May 2015 05:44:24 -0700 (PDT) Received: from fri2jcharbon-m1.vcorp.ad.vrsn.com ([217.30.88.7]) by mx.google.com with ESMTPSA id q4sm25421800wja.24.2015.05.05.05.44.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 May 2015 05:44:24 -0700 (PDT) Message-ID: <5548BB20.2020700@freebsd.org> Date: Tue, 05 May 2015 14:44:16 +0200 From: Julien Charbon User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: freebsd-net@freebsd.org CC: John Baldwin Subject: MFC-ing Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1row9mVeHLQaF67mn5k6tPBwtIQlsHrJV" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 May 2015 12:44:27 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1row9mVeHLQaF67mn5k6tPBwtIQlsHrJV Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi list, I was asked if it is possible to MFC r281599 in FreeBSD 10: --- Fix an old and well-documented use-after-free race condition in TCP timers: - Add a reference from tcpcb to its inpcb - Defer tcpcb deletion until TCP timers have finished --- https://svnweb.freebsd.org/base?view=3Drevision&revision=3D281599 First, I thought it was no possible as it touches struct tcp_timer/struct tcpcb_mem. Second, John pointed me that these two structures are used only internally. The only side effect I was able to find is the increase of struct tcpcb_mem size: - stable/10: struct tcpcb_mem size is 1024 bytes - stable/10 + tcp timer change: struct tcpcb_mem size is 1032 bytes - currently in head: struct tcpcb_mem size is 1048 bytes If you have extra concerns on MFC-ing this change please scream. Without nice yelps I plan to "MFC after: 1 month" (around May 16th). Thanks. -- Julien --1row9mVeHLQaF67mn5k6tPBwtIQlsHrJV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVSLsnAAoJEKVlQ5Je6dhx5ecIAJY06figfPivHZJ5Waugmqs4 IzBfWprlSceunaVnIKBChd76TpYtvqsKkweUQZn9EUhxIqHovIgVnIB2c8W/XPWs 78JiPBFH5jGYkSAR7/ekyFkDmEOR5gAcGqwtH2DgcIzUbTmIHBNjADrSnhmAow26 HjglhFBJUuRmubGTNKpDJld36D1+Yb8/GpqJcgsfgyPObhnlIcl/x4x7i6Yw0xp4 IVtqBPBDwV7172ZBpxjlyNtfw5y2gGx3+nRWZXjz4SL4oQxQuIYg8Tx4QL+rvtV6 SgoEiCrpKzk27iiZUoXVMOE/XQnF5nVxFGZwKJ7wkvJh69GshrDRCFznRV/A4DE= =ZRUX -----END PGP SIGNATURE----- --1row9mVeHLQaF67mn5k6tPBwtIQlsHrJV--