From owner-freebsd-ports Sun Mar 17 4:26:51 2002 Delivered-To: freebsd-ports@freebsd.org Received: from alcatraz.iptelecom.net.ua (alcatraz.iptelecom.net.ua [212.9.224.15]) by hub.freebsd.org (Postfix) with ESMTP id AF8ED37B405; Sun, 17 Mar 2002 04:25:51 -0800 (PST) Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5]) by alcatraz.iptelecom.net.ua (8.9.3/8.9.3) with ESMTP id OAA59675; Sun, 17 Mar 2002 14:24:43 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Received: from vega.vega.com (h3.228.dialup.iptcom.net [212.9.228.3]) by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id OAA03645; Sun, 17 Mar 2002 14:24:35 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vega.vega.com (8.11.6/8.11.3) with ESMTP id g2HCO3B10646; Sun, 17 Mar 2002 14:24:03 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Message-ID: <3C948B26.C227ECD8@FreeBSD.org> Date: Sun, 17 Mar 2002 14:25:10 +0200 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U) X-Accept-Language: en,uk,ru MIME-Version: 1.0 To: Alan Eldridge Cc: Will Andrews , Kris Kennaway , Will Andrews , ports@FreeBSD.org, ports@geeksrus.net Subject: Re: cvs commit: ports/x11/XFree86-4 Makefile Makefile.man pkg-plist pkg-plist.alpha pkg-plist.pc98 ports/x11/XFree86-4/files patch-2 patch-c patch-c2 patch-d patch-f patch-i810 patch-j patch-k patch-mouse patch-r128 patch-r128dri patch-r128xmesa patch-shm ... References: <200203162343.g2GNhjs90185@freefall.freebsd.org> <20020316171808.A15093@xor.obsecurity.org> <20020317022158.GK53073@squall.waterspout.com> <1016353719.256.16.camel@notebook> <20020317090147.GA67681@wwweasel.geeksrus.net> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Alan Eldridge wrote: > > On Sun, Mar 17, 2002 at 10:30:05AM +0200, Maxim Sobolev wrote: > > > >You can use the same approach as mozilla-{headers,embedded} use - i.e. > >use shared ${WRKSRC} to build all miniports. See www/mozilla/Makefile, > >www/mozilla-embedded/Makefile and www/mozilla-headers/Makefile. This > >also simplifies patches management, because you only need to add patch > >in one place, not in 9 separate places. > > Did you see my suggestion? > > either > WRKDIR!= cd ${PORTSDIR}/x11/XFree86 && make -V WRKDIR > or > WRKSRC!= cd ${PORTSDIR}/x11/XFree86 && make -V WRKSRC > > Also, unlike the mozilla-* ports, you have to force a make clean before > building any of the X miniports. They do some configuration stuff that is > positively vile and each one has to start with a clean tree; that may also > necessitate separate patch management. Then ALL_TARGET=clean all. > ============================================================ > Off topic for X, but I need to say this to sobomax while I think of it: > > Oooh, and that makes me think -- do the mozilla-* ports break if I set > my WRKDIR (in make.conf, for example) to something funny? Umm, yes.[1] > > Notes: > [1]Who says that my ${WRKDIR} for mozilla is going to be under > ${PORTSDIR}/www/mozilla? I can keep all my WRKDIRs in a separate tree, > and break the mozilla-* ports instantly. You need to do what I > suggested above for X in the mozilla-* ports. > > To sobomax: I'll PR that and we can continue discussion there. Nope, they do it correctly. The only correct way to more WRKSRC is to use WRKDIRPREFIX - and mozilla-* ports take it into consideration. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message