From owner-freebsd-current@FreeBSD.ORG Tue Oct 16 09:21:26 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 602D0E8F; Tue, 16 Oct 2012 09:21:26 +0000 (UTC) (envelope-from fabien.thomas@netasq.com) Received: from work.netasq.com (gwlille.netasq.com [91.212.116.1]) by mx1.freebsd.org (Postfix) with ESMTP id E56B18FC0C; Tue, 16 Oct 2012 09:21:24 +0000 (UTC) Received: from [10.2.1.1] (unknown [10.2.1.1]) by work.netasq.com (Postfix) with ESMTPSA id BB10E2705208; Tue, 16 Oct 2012 11:21:17 +0200 (CEST) Subject: Re: [CFT]hwpmc update for sandybridge-e Mime-Version: 1.0 (Apple Message framework v1283) From: Fabien Thomas In-Reply-To: Date: Tue, 16 Oct 2012 11:21:18 +0200 Message-Id: <15825760-628D-4073-813A-DD2449BDC6FB@netasq.com> References: <1349390777.5234.9.camel@powernoodle.corp.yahoo.com> To: hiren panchasara X-Mailer: Apple Mail (2.1283) Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-current , Davide Italiano X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2012 09:21:26 -0000 Le 16 oct. 2012 =E0 02:49, hiren panchasara a =E9crit : >=20 >=20 > On Mon, Oct 15, 2012 at 1:12 AM, Fabien Thomas = wrote: >=20 > Le 13 oct. 2012 =E0 00:54, hiren panchasara a =E9crit : >=20 > > > > > > On Fri, Oct 5, 2012 at 1:05 AM, Fabien Thomas = wrote: > > > > Le 5 oct. 2012 =E0 10:00, Fabien Thomas a =E9crit : > > > > > > > > Le 5 oct. 2012 =E0 00:46, Sean Bruno a =E9crit : > > > > > >> So, I did the bear minimum and kind of hacked things together = without > > >> understanding precisely what I was doing, and I was able to = massage the > > >> sandybridge-e CPUs into giving me some basic functions. > > >> > > >> Comments or concerns before I commit this? > > >> > > >> http://people.freebsd.org/~sbruno/pmc_sandybridge.txt > > > > > > Hi Sean, > > > > > > The only modification required is this one > > > http://svnweb.freebsd.org/base?view=3Drevision&revision=3D237196 > > > > > > but davide@ removed it for a problem that need to be looked at. > > > > Looking at the doc this CPU require a full set of PMC as the list of = event are different. > > So this mean full manpage, full event list, =85 > > > > Doc: > > " > > The events in Table 19-3 apply to > > processors with CPUID signature of DisplayFamily_DisplayModel = encoding with the > > following values: 06_2AH and 06_2DH. The events in Table 19-4 apply = to processors > > with CPUID signature 06_2AH. The events in Table 19-5 apply to = processors with > > CPUID signature 06_2DH. > > " > > > > Required change will be the same as this commit if you want to look = at it: > > http://svnweb.freebsd.org/base?view=3Drevision&revision=3D240164 > > > > Hi All, > > > > With help of Sean, I've prepared another semi-working patch: > > http://www.strugglingcoder.info/patches/hwpmc_sbx_1.txt >=20 > Great, i've quickly looked at the patch: >=20 > I'm not sure to understand why you have removed code in your case for = uncore. > If you dont want to support remove it like for ivy bridge. >=20 > Thanks Fabien for getting back quickly. As I am not clear about uncore = support, I've removed it entirely as you suggested. I've tried to = incorporate other comments too. >=20 > New set of diffs, pmccontrol and pmctest.py results are here: >=20 > http://www.strugglingcoder.info/patches/hwpmc_sbx_2.txt > http://www.strugglingcoder.info/patches/pmccontrol_2.txt > http://www.strugglingcoder.info/patches/pmctestpy_2.txt >=20 > I now have following event counters failing from pmctest.py script: > CYCLE_ACTIVITY.CYCLES_L2_PENDING >=20 I think you missed IAP_F_FM. I will look at the new diff later. > BACLEARS.ANY > L2_TRANS.DEMAND_DATA_RD > L2_TRANS.RF0 > SQ_MISC.SPLIT_LOCK > I am not quite sure why these are failing. Will continue looking into = it. >=20 > Appreciate your help, > Hiren