From nobody Mon Oct 7 15:08:30 2024 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XMjG96hwhz5YJrd for ; Mon, 07 Oct 2024 15:08:33 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XMjG945w9z4NBL; Mon, 7 Oct 2024 15:08:33 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTPS id xmhfsBU5TMArNxpLcsRFuV; Mon, 07 Oct 2024 15:08:32 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id xpLbsTNXS2M9qxpLcsuImy; Mon, 07 Oct 2024 15:08:32 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=ce5xrWDM c=1 sm=1 tr=0 ts=6703f970 a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=IkcTkHD0fZMA:10 a=DAUX931o1VcA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=Rqjl16dpY3m5TfOLMpoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 9AC16254A; Mon, 07 Oct 2024 08:08:30 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 939DC334; Mon, 07 Oct 2024 08:08:30 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Mark Johnston cc: "David E. Cross" , FreeBSD Hackers Subject: Re: Review D38047 ... and then there was one.... In-reply-to: References: <21941f7f-ce32-e277-a565-b1db3b3841ab@crossfamilyweb.com> Comments: In-reply-to Mark Johnston message dated "Mon, 07 Oct 2024 10:07:08 -0400." List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Date: Mon, 07 Oct 2024 08:08:30 -0700 Message-Id: <20241007150830.939DC334@slippy.cwsent.com> X-CMAE-Envelope: MS4xfD7VxpbJ0IPl/Z7CWCRXBHcNnu6tMbEoB2Fp7Wx0WuAOQBwR6Dn9QVt40P+pjdJrlV2tBEzRiymdmJWMZsj8pH52dPN+Yga5TjPL8ZdrqU89P9whozm1 HtQnQqUFyYiwnrc9xmxzW4JQUbpmzJLEME5uD1TyvTs3l1GO5PVv2GoNs2lleh6R1HeOwnnUYT8X2iU3I5kMy52DMDQaPzC9RvgikqBo9jHS6T08r7IbU3Rf 3LRsRIKpSfdHemNdF6YqygmfQ1QaF8KJOCJ74YqS55w= X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4XMjG945w9z4NBL X-Spamd-Bar: ---- In message , Mark Johnston writes: > On Sun, Oct 06, 2024 at 02:35:18PM -0400, David E. Cross wrote: > > As I have been prodding about open reviews, there is now only one that > > hasn't had any action.  One that is complete and in main (OMGYES), and one > > that is at the finish line (I think). > > > > > > That leaves just D38047 ( https://reviews.freebsd.org/D38047 ) ... Submitte > d > > Jan 13, **2023**, had initial peer review requests, I made all requested > > changes (or explained why I didn't)  Made my last substantive changes Aug 4 > , > > **2023**, I have since then semi-regularly updated with fresh rebases, but > > no other changes. > > > > > > Please, love to get some eyes on this.  As it stands nscd is completely > > useless for LDAP for getgroupmembership (and really ANY implementation that > > defines a specific implementation of getgroupmembership, since it will then > > bypass the non-existent NSCD version).  Additionally it fixes bugs with > > negative caching as well as increases thread safety. > > One problem with this patch is that it fixes several bugs at once. > Though the process can be a bit tedious, it's much easier to review > smaller, self-contained patches which fix a single problem. The change > to the nscd Makefile plus the cycle prevention symbol rename, for > instance, can be committed on its own. Yes. I was about to suggest this. Plus, any proposed commit log message must answer the questions why, what and how. With special attention to why. > > I left some comments on the review in any case. If you could split the > patch into several smaller ones, it'd be greatly appreciated. > > > I've been running this successfully with LDAP for years now. > -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0