From owner-freebsd-current@FreeBSD.ORG  Mon Aug 25 01:50:11 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EEAF616A4BF
	for <freebsd-current@FreeBSD.ORG>;
	Mon, 25 Aug 2003 01:50:11 -0700 (PDT)
Received: from spider.deepcore.dk
	(cpe.atm2-0-56339.0x50c6aa0a.abnxx2.customer.tele.dk [80.198.170.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E240F43F3F
	for <freebsd-current@FreeBSD.ORG>;
	Mon, 25 Aug 2003 01:50:09 -0700 (PDT)
	(envelope-from sos@spider.deepcore.dk)
Received: from spider.deepcore.dk (localhost.deepcore.dk [127.0.0.1])
	by spider.deepcore.dk (8.12.9/8.12.9) with ESMTP id h7P8o427091998;
	Mon, 25 Aug 2003 10:50:04 +0200 (CEST)
	(envelope-from sos@spider.deepcore.dk)
Received: (from sos@localhost)
	by spider.deepcore.dk (8.12.9/8.12.9/Submit) id h7P8o4Dq091997;
	Mon, 25 Aug 2003 10:50:04 +0200 (CEST)
From: Soren Schmidt <sos@spider.deepcore.dk>
Message-Id: <200308250850.h7P8o4Dq091997@spider.deepcore.dk>
In-Reply-To: <200308250820.h7P8KDp2063902@mercury.infolab.ne.jp>
To: HATANOU Tomomi <hatanou@infolab.ne.jp>
Date: Mon, 25 Aug 2003 10:50:03 +0200 (CEST)
X-Mailer: ELM [version 2.4ME+ PL99f (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=ISO-8859-1
X-mail-scanned: by DeepCore Virus & Spam killer v1.3
cc: freebsd-current@FreeBSD.ORG
Subject: Re: HEADS UP! ATAng committed
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Aug 2003 08:50:12 -0000

It seems HATANOU Tomomi wrote:
> >> Coolness. Judging from the CVS log, it also gets ATA out under Giant? 
> >
> >Yes it does.
> 
> I've noticed that, in ata-raid.c:ar_rebuid(), Giant is
> locked and never unlocked.  Is it ok?

It is only locked in the rebuild thread, its not needed anymore actually.

Anyhow ata-raid is about to change radically to support the new chips
out there and to get rid of all the really bad/ugly diskdriver strategy 
calls which abuses bio structs and what not.

-Søren