From owner-freebsd-geom@FreeBSD.ORG  Fri Mar 26 03:48:38 2004
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CA72C16A4CE; Fri, 26 Mar 2004 03:48:38 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3546F43D2F; Fri, 26 Mar 2004 03:48:38 -0800 (PST)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i2QBmbAZ002249;
	Fri, 26 Mar 2004 12:48:37 +0100 (CET)
	(envelope-from phk@phk.freebsd.dk)
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Fri, 26 Mar 2004 12:43:43 +0100."
             <20040326114343.GG8930@darkness.comp.waw.pl> 
Date: Fri, 26 Mar 2004 12:48:37 +0100
Message-ID: <2248.1080301717@critter.freebsd.dk>
cc: geom@FreeBSD.org
cc: Lukas Ertl <le@FreeBSD.org>
Subject: Re: Problem with g_unload_class() 
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Mar 2004 11:48:39 -0000

In message <20040326114343.GG8930@darkness.comp.waw.pl>, Pawel Jakub Dawidek wr
ites:
>
>--jk5HhkA9Kov5Oxsi
>Content-Type: text/plain; charset=iso-8859-2
>Content-Disposition: inline
>Content-Transfer-Encoding: quoted-printable
>
>On Fri, Mar 26, 2004 at 12:34:08PM +0100, Poul-Henning Kamp wrote:
>+> >Anyway this will be a big change.
>+>=20
>+> No it isn't.
>
>Hmm, we can simulate such functionality, by doing only tests
>(can we remove this geom? Yes - block geom, return 0;
>No - unblock all geoms, return an error) in *_destroy_geom()
>function and do real removals in *_fini().

No, that is not what _fini is for.

The solution would be to give destroy_geom() and argument
which can be one of three values:
	TEST
	COMMIT
	ABANDON

This is classical CS theory, there is no need to reinvent
the hot water or the deep plate.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.