From owner-freebsd-hackers@FreeBSD.ORG Mon Jan 12 03:23:18 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B460916A4CE; Mon, 12 Jan 2004 03:23:18 -0800 (PST) Received: from cs.huji.ac.il (cs.huji.ac.il [132.65.16.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 928B543D64; Mon, 12 Jan 2004 03:23:17 -0800 (PST) (envelope-from danny@cs.huji.ac.il) Received: from pampa.cs.huji.ac.il ([132.65.80.32] ident=danny) by cs.huji.ac.il with esmtp id 1Ag0A7-00082f-Cc; Mon, 12 Jan 2004 13:23:15 +0200 X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4 To: Robert Watson In-reply-to: Your message of Sun, 11 Jan 2004 11:41:17 -0500 (EST) . Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 12 Jan 2004 13:23:15 +0200 From: Danny Braniss Message-Id: cc: hackers@freebsd.org Subject: Re: diskless problems X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jan 2004 11:23:18 -0000 i re-applied the patches to the latest bootp.c, and took care not to botch up the tabs, but my user friendly emacs was not too helpful :-) (the diff is now about 500 lines) the PR is: http://www.freebsd.org/cgi/query-pr.cgi?pr=61239 thanks, danny > Sounds very interesting indeed. Could you: > > (1) Update it to bootp.c:1.5; this just removed 'register', and it looks > like you've already done that. > > (2) Restore the original file style -- right now, it's a very hard to read > diff because you use different tabbing, function prototypes, etc, so > it's hard to isolate and read the changes. There's probably some room > for style convergence (new function prototypes), but we have a > long-standing tradition of committing style and functional chaanges > separately so cvs diff is maximally useful between revisions. It > looks like the main difference is that you use four space tabs, and > the original file uses real tab characters. > > Then if you could file a PR and drop me the PR number by e-mail, that > would be great. I can do the style stuff if necessary, but I figured > since you're much more familiar with the changes, it might not be a bad > idea if you did it :-). > > Robert N M Watson FreeBSD Core Team, TrustedBSD Projects > robert@fledge.watson.org Senior Research Scientist, McAfee Research >