From owner-freebsd-rc@FreeBSD.ORG  Tue Mar 28 02:50:23 2006
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
X-Original-To: freebsd-rc@hub.freebsd.org
Delivered-To: freebsd-rc@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2451716A400
	for <freebsd-rc@hub.freebsd.org>; Tue, 28 Mar 2006 02:50:23 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E553343D46
	for <freebsd-rc@hub.freebsd.org>; Tue, 28 Mar 2006 02:50:22 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2S2oLvu039655
	for <freebsd-rc@freefall.freebsd.org>; Tue, 28 Mar 2006 02:50:21 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2S2oLeK039648;
	Tue, 28 Mar 2006 02:50:21 GMT (envelope-from gnats)
Date: Tue, 28 Mar 2006 02:50:21 GMT
Message-Id: <200603280250.k2S2oLeK039648@freefall.freebsd.org>
To: freebsd-rc@FreeBSD.org
From: Ganbold <ganbold@micom.mng.net>
Cc: 
Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a
 proper RCng script (dansguardian)
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Ganbold <ganbold@micom.mng.net>
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Mar 2006 02:50:23 -0000

The following reply was made to PR bin/94767; it has been noted by GNATS.

From: Ganbold <ganbold@micom.mng.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a
 proper RCng script (dansguardian)
Date: Tue, 28 Mar 2006 11:49:07 +0900

 In Dragonfly rcorder code, those lines which frees memory are commented 
 out.
 Clearer way will be just to delete those lines.
 In any case I just commented out those lines, since it can be used later 
 on.
 So the patch would be:
 
 --- rcorder.c.orig      Tue Jan 17 16:01:00 2006
 +++ rcorder.c   Mon Mar 27 16:41:49 2006
 @@ -757,8 +757,8 @@
                 r_tmp = r;
                 satisfy_req(r, fnode->filename);
                 r = r->next;
 -               if (was_set == 0)
 -                       free(r_tmp);
 +/*             if (was_set == 0)*/
 +/*                     free(r_tmp);*/
         }
         fnode->req_list = NULL;
 
 @@ -797,10 +797,10 @@
         }
 
         DPRINTF((stderr, "nuking %s\n", fnode->filename));
 -       if (was_set == 0) {
 -               free(fnode->filename);
 -               free(fnode);
 -       }
 +/*     if (was_set == 0) {*/
 +/*             free(fnode->filename);*/
 +/*             free(fnode);*/
 +/*     }*/
  }
 
  void