From owner-freebsd-current@FreeBSD.ORG Tue Dec 28 11:06:49 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D88B516A4CE; Tue, 28 Dec 2004 11:06:49 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id D131643D31; Tue, 28 Dec 2004 11:06:48 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iBSB6bm7008869; Tue, 28 Dec 2004 13:06:37 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 37033-13; Tue, 28 Dec 2004 13:06:35 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iBSB6Znb008863 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 28 Dec 2004 13:06:35 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id iBSB6i7A017290; Tue, 28 Dec 2004 13:06:44 +0200 (EET) (envelope-from ru) Date: Tue, 28 Dec 2004 13:06:44 +0200 From: Ruslan Ermilov To: S?ren Schmidt Message-ID: <20041228110644.GB14010@ip.net.ua> References: <20041223221047.GB6049@ip.net.ua> <20041224094127.GA75931@ip.net.ua> <41CC425C.7050906@DeepCore.dk> <20041224220821.GB86330@ip.net.ua> <41CC9BDA.7020203@DeepCore.dk> <20041224233021.GA43419@ip.net.ua> <41CFEFAF.8040100@DeepCore.dk> <20041227141310.GA95767@ip.net.ua> <41D03AA4.3020908@DeepCore.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GRPZ8SYKNexpdSJ7" Content-Disposition: inline In-Reply-To: <41D03AA4.3020908@DeepCore.dk> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: current@FreeBSD.ORG cc: Soren Schmidt Subject: Re: ATA regression [PATCH] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Dec 2004 11:06:50 -0000 --GRPZ8SYKNexpdSJ7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 27, 2004 at 05:39:00PM +0100, S?ren Schmidt wrote: > Ruslan Ermilov wrote: >=20 > >>Hmm, on the exact same controller with two SATA drives on it and stock= =20 > >>current it "just works" (tm) here, I cannot reproduce the problem... > >>Are you sure its a stock GENERIC kernel with no local mods/patches ? > >> > >Yes. This is the Asus SK8N motherboard, but I only have one PATA > >drive attached to 3rd (PATA) channel; first two channels (SATA) > >don't have any drives attached. Can you check in this configuration? >=20 >=20 > atapci0: port=20 > 0xb800-0xb87f,0xd000-0xd00f,0xd400-0xd43f mem=20 > 0xfc800000-0xfc81ffff,0xfd000000-0xfd000fff irq 18 at device 5.0 on pci0 > atapci0: failed: rid 0x20 is memory, requested 4 > ata2: channel #0 on atapci0 > ata3: channel #1 on atapci0 > ata4: channel #2 on atapci0 > ... > atapci1: port=20 > 0xb000-0xb00f,0x376,0x170-0x177,0x3f6,0x1f0-0x1f7 at device 15.1 on pci0 > ata0: channel #0 on atapci1 > ata1: channel #1 on atapci1 > ... > ad0: 13042MB [26500/16/63] at ata0-master UDMA= 33 > acd0: DVDRAM at ata0-slave PIO4 > afd0: REMOVABLE at ata1-master PIO3 > acd1: CDRW at ata1-slave PIO4 > ad1: 38166MB [77545/16/63] at ata4-master UDMA100 >=20 > That works just as well... >=20 OK, but the fact is that if I revert sys/dev/ata/ to just before this change, with otherwise -CURRENT sources (except for keeping atapi-cd.c at its current version), it all works perfectly again. : sos 2004-12-08 10:02:41 UTC : : FreeBSD src repository : : Modified files: : sys/dev/ata ata-chipset.c ata-pci.h : Log: : Add first shot on support for the new Promise SATAII chips. : : HW donated by: pil.dk : : Revision Changes Path : 1.93 +109 -49 src/sys/dev/ata/ata-chipset.c : 1.36 +10 -2 src/sys/dev/ata/ata-pci.h So I analyzed what was changed in this ata-chipset.c revision when it comes to my chip, and tried the following patch, and it brought me back my ad8 drive: %%% Index: ata-chipset.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/dev/ata/ata-chipset.c,v retrieving revision 1.97 diff -u -p -r1.97 ata-chipset.c --- ata-chipset.c 24 Dec 2004 13:36:04 -0000 1.97 +++ ata-chipset.c 28 Dec 2004 10:59:06 -0000 @@ -1607,7 +1607,7 @@ ata_promise_mio_reset(struct ata_channel (ATA_INL(ctlr->r_res2, 0xc012c) & ~0x00000f9f)); mtx_unlock(&hpktp->mtx); } - else if (ctlr->chip->cfg2 & PRSATA) { + else if (ctlr->chip->cfg2 & (PRSATA | PRCMBO)) { u_int32_t status =3D 0; int timeout; =20 %%% Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --GRPZ8SYKNexpdSJ7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFB0T5EqRfpzJluFF4RAtnQAJ4uLQba1W5ijzm1uTXK8v364uCI+QCgisYZ CUNMPFi5Uk1gJNtwSurhc7k= =uyTT -----END PGP SIGNATURE----- --GRPZ8SYKNexpdSJ7--