Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 May 2011 15:21:56 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Marcel Moolenaar <marcel@FreeBSD.org>
Cc:        svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   Re: svn commit: r221242 - stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
Message-ID:  <20110501132156.GB3245@garage.freebsd.pl>
In-Reply-To: <201104300528.p3U5StZN031259@svn.freebsd.org>
References:  <201104300528.p3U5StZN031259@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Nq2Wo0NMKNjxTN9z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 30, 2011 at 05:28:55AM +0000, Marcel Moolenaar wrote:
> Author: marcel
> Date: Sat Apr 30 05:28:54 2011
> New Revision: 221242
> URL: http://svn.freebsd.org/changeset/base/221242
>=20
> Log:
>   Unbreak non-x86 and in particular ia64, The default stack size
>   on ia64 is 32KB. Unconditionally hardcoding a 16KB stack for
>   reasons of increasing the stack size on i386 is just wrong. If
>   the size was indeed expressed in terms of pages, as the commit
>   log suggested, then it would happen to be just right for ia64,
>   though only accidentally.
>  =20
>   Pointy hat: avg, pjd

Marcel, you already know my opinion that I don't agree with this change.
I don't think you are going to update the code once new architecture
arrive. This change also reduces thread stack size for already existing
architectures (arm and mips).
I'd prefer to either commit my patch that protects against passing stack
size smaller than the default on given architecture or commit what we
have in HEAD.

> --- stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c	Sat Apr=
 30 02:44:15 2011	(r221241)
> +++ stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c	Sat Apr=
 30 05:28:54 2011	(r221242)
> @@ -129,6 +129,7 @@ void
>  txg_sync_start(dsl_pool_t *dp)
>  {
>  	tx_state_t *tx =3D &dp->dp_tx;
> +	size_t stksize =3D 0;
> =20
>  	mutex_enter(&tx->tx_sync_lock);
> =20
> @@ -146,7 +147,10 @@ txg_sync_start(dsl_pool_t *dp)
>  	 * 32-bit x86.  This is due in part to nested pools and
>  	 * scrub_visitbp() recursion.
>  	 */
> -	tx->tx_sync_thread =3D thread_create(NULL, 16<<10, txg_sync_thread,
> +#ifdef __i386__
> +	stksize =3D 16 << 10;
> +#endif
> +	tx->tx_sync_thread =3D thread_create(NULL, stksize, txg_sync_thread,
>  	    dp, 0, &p0, TS_RUN, minclsyspri);
> =20
>  	mutex_exit(&tx->tx_sync_lock);

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://yomoli.com

--Nq2Wo0NMKNjxTN9z
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iEYEARECAAYFAk29XnMACgkQForvXbEpPzTpvwCg5XqB7Ws8HXbTTXGOcHNycdE5
hV0AnRF9zTitawbGVsKWXI/4Qq1R+wKP
=nsBi
-----END PGP SIGNATURE-----

--Nq2Wo0NMKNjxTN9z--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110501132156.GB3245>