From owner-p4-projects  Tue Nov  5 10:33: 0 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D3FB137B404; Tue,  5 Nov 2002 10:32:58 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6C56937B401
	for <perforce@freebsd.org>; Tue,  5 Nov 2002 10:32:58 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2591743E77
	for <perforce@freebsd.org>; Tue,  5 Nov 2002 10:32:58 -0800 (PST)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id gA5IVBmV049042
	for <perforce@freebsd.org>; Tue, 5 Nov 2002 10:31:11 -0800 (PST)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id gA5IVBVD049039
	for perforce@freebsd.org; Tue, 5 Nov 2002 10:31:11 -0800 (PST)
Date: Tue, 5 Nov 2002 10:31:11 -0800 (PST)
Message-Id: <200211051831.gA5IVBVD049039@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 20710 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://perforce.freebsd.org/chv.cgi?CH=20710

Change 20710 by rwatson@rwatson_tislabs on 2002/11/05 10:30:43

	Disallow changing Biba label elements via mac_exec(), since we
	currently don't have the machinery in place for that in Biba.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/security/mac_biba/mac_biba.c#181 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/security/mac_biba/mac_biba.c#181 (text+ko) ====

@@ -2047,7 +2047,20 @@
     struct label *label, struct image_params *imgp,
     struct label *execlabel)
 {
-	struct mac_biba *subj, *obj;
+	struct mac_biba *subj, *obj, *exec;
+	int error;
+
+	if (execlabel != NULL) {
+		/*
+		 * We currently don't permit labels to be changed at
+		 * exec-time as part of Biba, so disallow non-NULL
+		 * Biba label elements in the execlabel.
+		 */
+		exec = SLOT(execlabel);
+		error = biba_atmostflags(exec, 0);
+		if (error)
+			return (error);
+	}
 
 	if (!mac_biba_enabled)
 		return (0);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message