From owner-freebsd-bugs Mon Jan 18 20:13:46 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA06983 for freebsd-bugs-outgoing; Mon, 18 Jan 1999 20:13:46 -0800 (PST) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from helium.clari.net.au (helium.clari.net.au [203.8.14.114]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA06976 for ; Mon, 18 Jan 1999 20:13:38 -0800 (PST) (envelope-from danny@hilink.com.au) Received: from localhost (danny@localhost) by helium.clari.net.au (8.8.8/8.8.8) with SMTP id PAA23233 for ; Tue, 19 Jan 1999 15:13:25 +1100 (EST) (envelope-from danny@hilink.com.au) X-Authentication-Warning: helium.clari.net.au: danny owned process doing -bs Date: Tue, 19 Jan 1999 15:13:25 +1100 (EST) From: "Daniel O'Callaghan" X-Sender: danny@helium.clari.net.au Reply-To: "Daniel O'Callaghan" To: freebsd-bugs@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/yacc/test ftp.y (fwd) Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org My latest commit was tidying up a y2k nit in src/usr.bin/yacc/test/ftp.y Peter Jeremy pointed out that it was a test directory, and changes to source need corresponding changes to the output comparison files. On further inspection, neither of us can see that yacc/test/ is usable in its current form. Should the test/ subdir of usr.bin/yacc be moved to the Attic or fixed or what? The output comparison files are already useless for testing yacc. Danny ---------- Forwarded message ---------- Date: Tue, 19 Jan 1999 14:16:21 +1100 From: Peter Jeremy To: danny@hilink.com.au Subject: Re: cvs commit: src/usr.bin/yacc/test ftp.y Hi Danny, >I can't see how to actually run the test from the Makefile. I can't either. Possibly the original Makefile supported it, but it wasn't carried across to the 4.4BSD Makefile. >'diff -u ftp.tab.c y.tab.c' produces a lot of output. Looking at the output, it seems that someone has done some cleaning up in the code generated by yacc - adding const's and various constructs to stop some gcc warnings. Reading back thru the RCS logs, it seems that a variety of fixes have been made in skeleton.c, without the corresponding changes in the expected output files. >What to do? I suspect the entire test directory can be junked, but you should probably discuss that with core (or at least Bruce Evans or Peter Wemm who seem to have originated most of the recent changes). Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message