From owner-freebsd-hackers@FreeBSD.ORG Fri Jul 2 23:34:29 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EAC3F106566B for ; Fri, 2 Jul 2010 23:34:29 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id AF54A8FC15 for ; Fri, 2 Jul 2010 23:34:29 +0000 (UTC) Received: by iwn35 with SMTP id 35so1800683iwn.13 for ; Fri, 02 Jul 2010 16:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=cs4oBMDvH741PYW5L4xERSGRNicts+o1Se6LsNXOXzM=; b=xod0SVgi1j023bndRiF7LH+cW+RutlwnK5H2aJSwVIgXJ9Z1+4kA7dCqTy5gGnefQa iotLc6ZfCJzOQbkxKHiXzVis/Ev9wYjfqF9SX6Nrdugf8SX9KEWAS9ZaS/80b+MQ01m6 wZyf6GbfDCud962HsxJQY4cjeBka1Aw8/db+4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=AD5TcG680kmVyEkJB3HTA5AXQlu67iimX5uXEnuLKLRRMCc+nJa1HJLc3zTPsoE7Dv aSKPfxJyCsK2QU39aESYy3Xj5lp6m9fgrw+PKYNaZ3MO8SKDcVxCgy4pthXV8Yo8OPtW OBL1JiDFquAjqxwsuwSmfZ2v6EPL5vCf+oDBQ= MIME-Version: 1.0 Received: by 10.42.6.75 with SMTP id 11mr491733icz.38.1278113668957; Fri, 02 Jul 2010 16:34:28 -0700 (PDT) Received: by 10.42.5.78 with HTTP; Fri, 2 Jul 2010 16:34:28 -0700 (PDT) In-Reply-To: References: Date: Fri, 2 Jul 2010 16:34:28 -0700 Message-ID: From: Matthew Fleming To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org Subject: Re: Using lex in a shared library X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2010 23:34:30 -0000 On Fri, Jul 2, 2010 at 4:02 PM, Garrett Cooper wrote: > On Fri, Jul 2, 2010 at 2:51 PM, Matthew Fleming wrote: >> I have the following Makefile for a shared library at $work: >> >> ISI_TOP=3D =A0 =A0 =A0 =A0../.. >> >> LIB=3D =A0 =A0 =A0 =A0 =A0 =A0isi_date >> SHLIB_MAJOR=3D =A0 =A01 >> SHLIB_MINOR=3D =A0 =A00 >> SRCS=3D =A0 =A0 =A0 =A0 =A0 date.c date_parser.new.c lex.yy.c >> INCS=3D =A0 =A0 =A0 =A0 =A0 date.h >> INCLUDEDIR=3D =A0 =A0 /usr/include/isi_date >> >> YFLAGS+=3D =A0 =A0 =A0 =A0-vt >> FLEX=3D =A0 =A0 =A0 =A0 =A0 /usr/bin/flex >> LDADD=3D =A0 =A0 =A0 =A0 =A0-ll >> >> CLEANFILES+=3D =A0 =A0date_parser.new.c y.tab.h y.tab.c lex.yy.c y.outpu= t \ >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0check_date.log test >> >> lex.yy.c: date_lexer.new.l >> =A0 =A0 =A0 =A0${FLEX} $> >> >> CFLAGS+=3D =A0 =A0 =A0 =A0-I${.CURDIR} >> #CFLAGS+=3D =A0 =A0 =A0 -g >> >> .include "${ISI_TOP}/isi.lib.mk" >> >> >> >> This builds fine as on i386. =A0I'm trying to get all our user-space to >> be 64-bit clean, and I run into an error when building on amd64: >> >> /data/sb/BR_MDF_64CLEAN/obj/data/sb/BR_MDF_64CLEAN/src/tmp/usr/bin/ld: >> /data/sb/BR_MDF_64CLEAN/obj/data/sb/BR_MDF_64CLEAN/src/tmp/usr/lib/libl.= a(libyywrap.o): >> relocation R_X86_64_32 can not be used when making a shared object; >> recompile with -fPIC >> /data/sb/BR_MDF_64CLEAN/obj/data/sb/BR_MDF_64CLEAN/src/tmp/usr/lib/libl.= a: >> could not read symbols: Bad value >> >> The following diff makes the compile work, but I have no idea (yet) >> whether this will run, if it's the right solution, etc. >> >> >> Index: usr.bin/lex/lib/Makefile >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- usr.bin/lex/lib/Makefile =A0 =A0(revision 153343) >> +++ usr.bin/lex/lib/Makefile =A0 =A0(working copy) >> @@ -4,11 +4,16 @@ >> >> =A0LIB=3D =A0 =A0ln >> =A0SRCS=3D =A0 libmain.c libyywrap.c >> -NO_PIC=3D >> +#NO_PIC=3D >> >> +SHLIB_MAJOR=3D =A0 1 >> +SHLIB_MINOR=3D =A0 0 >> + >> =A0.if ${MK_INSTALLLIB} !=3D "no" >> =A0LINKS=3D =A0${LIBDIR}/libln.a ${LIBDIR}/libl.a >> =A0LINKS+=3D =A0 =A0 =A0 =A0${LIBDIR}/libln.a ${LIBDIR}/libfl.a >> +LINKS+=3D =A0 =A0 =A0 =A0${LIBDIR}/libln.so ${LIBDIR}/libl.so >> +LINKS+=3D =A0 =A0 =A0 =A0${LIBDIR}/libln${LIB_SUFFIX}.so ${LIBDIR}/libl= ${LIB_SUFFIX}.so >> =A0.endif >> >> =A0.if ${MK_PROFILE} !=3D "no" > > The static-only version was done on purpose: > > Revision 1.2: download - view: text, markup, annotated =A0- select for di= ffs > Thu Aug 25 23:11:07 1994 UTC (15 years, 10 months ago) by wollman > Branches: MAIN > CVS tags: RELENG_2_1_7_RELEASE, RELENG_2_1_6_RELEASE, > RELENG_2_1_6_1_RELEASE, RELENG_2_1_5_RELEASE, RELENG_2_1_0_RELEASE, > RELENG_2_1_0_BP, RELENG_2_0_5_RELEASE, RELENG_2_0_5_BP, > RELENG_2_0_5_ALPHA, RELENG_2_0_5, RELEASE_2_0, BETA_2_0, ALPHA_2_0 > Branch point for: RELENG_2_1_0 > Diff to: previous 1.1: preferred, colored > Changes since revision 1.1: +2 -8 lines > > We really, really /don't/ want to have a shared lex library. =A0Also, > current users should note that the old 1.1.5 lex can't process the > new scan.l, so you have to copy initscan.c to obj/scan.c before it will > build. > > Garrett Wollman probably has more information about why this was done. > > I think that fixing the lib to build with the appropriate options (not > -m32, or CPUTYPE =3D> some 32-bit x86 variant, etc) is what really needs > to be done here. I guess I'm still confused. The isi_date library compiles fine if it's for i386, but switching to amd64 gives this error. Since I didn't specify any -m32 flags or anything, and it's essentially using the standard bsd.lib.mk magic, I am trying to figure out why the 32-bit isi_date.1.so built and the 64-bit one won't. Was the 32-bit version building successfully an unfortunate fluke? What build flags would get the shared library to link with -ll? Unfortunately, I didn't write this library, and I don't know anything about lex(1), so if I need my own yywrap() that might be fine, but I wouldn't have the first clue what to put in there. :-( Thanks, matthew