From owner-cvs-all@FreeBSD.ORG Sat Nov 22 19:09:27 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D85D16A4CE for ; Sat, 22 Nov 2003 19:09:27 -0800 (PST) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mx1.FreeBSD.org (Postfix) with SMTP id F14E943FDD for ; Sat, 22 Nov 2003 19:09:24 -0800 (PST) (envelope-from tmoestl@gmx.net) Received: (qmail 1782 invoked by uid 65534); 23 Nov 2003 03:09:23 -0000 Received: from p508E7AB5.dip.t-dialin.net (EHLO timesink.dyndns.org) (80.142.122.181) by mail.gmx.net (mp013) with SMTP; 23 Nov 2003 04:09:23 +0100 X-Authenticated: #5374206 Received: by rota (Postfix, from userid 1001) id 104F7BD; Sun, 23 Nov 2003 04:10:37 +0100 (CET) Date: Sun, 23 Nov 2003 04:10:36 +0100 From: Thomas Moestl To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20031123031036.GA16180@timesink.dyndns.org> Mail-Followup-To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200311230302.hAN3209U045821@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200311230302.hAN3209U045821@repoman.freebsd.org> User-Agent: Mutt/1.5.5.1i Subject: Re: cvs commit: src/sys/netinet in_pcb.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Nov 2003 03:09:27 -0000 On Sat, 2003/11/22 at 19:02:00 -0800, Thomas Moestl wrote: > tmm 2003/11/22 19:02:00 PST > > FreeBSD src repository > > Modified files: > sys/netinet in_pcb.c > Log: > bzero() the the sockaddr used for the destination address for > rtalloc_ign() in in_pcbconnect_setup() before it is filled out. > Otherwise, stack junk would be left in sin_zero, which could > cause host routes to be ignored because they failed the comparison > in rn_match(). > This should fix the wrong source address selection for connect() to > 127.0.0.1, among other things. > > Reviewed by: sam ^, andre (oops). - Thomas -- Thomas Moestl http://www.tu-bs.de/~y0015675/ http://people.FreeBSD.org/~tmm/ PGP fingerprint: 1C97 A604 2BD0 E492 51D0 9C0F 1FE6 4F1D 419C 776C