Date: Wed, 13 Apr 2022 21:04:12 +0000 From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 256511] UFS assertion failure when shutting down from single-user mode Message-ID: <bug-256511-3630-83Cq6of9VQ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-256511-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-256511-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256511 --- Comment #8 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dd7d8cc9891507ec3d2dcd9334be2afade= 1ed9d0b commit d7d8cc9891507ec3d2dcd9334be2afade1ed9d0b Author: Robert Wing <rew@FreeBSD.org> AuthorDate: 2022-03-07 19:18:03 +0000 Commit: Robert Wing <rew@FreeBSD.org> CommitDate: 2022-04-13 20:59:12 +0000 ffs_mount(): return early if namei() fails to lookup disk device With soft updates enabled, an INVARIANTS panic is hit in ffs_unmount(). The problem occurs in ffs_mount() when upgrading a mount from ro->rw. During a mount update, the soft update code gets set up but doesn't get cleaned up if namei() fails when looking up the disk device. Avoid this scenario by looking up the disk device first and bail early if the namei() lookup fails. PR: 256511 Reviewed by: mckusick, kib Differential Revision: https://reviews.freebsd.org/D30870 (cherry picked from commit 0455cc7104ec8e8dd54b3f44049112a5a8ca329c) sys/ufs/ffs/ffs_vfsops.c | 148 +++++++++++++++++++++++--------------------= ---- 1 file changed, 72 insertions(+), 76 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-256511-3630-83Cq6of9VQ>