From owner-freebsd-current@FreeBSD.ORG  Tue Jan  3 11:35:48 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ACC02106564A;
	Tue,  3 Jan 2012 11:35:48 +0000 (UTC)
	(envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (gw.catspoiler.org [75.1.14.242])
	by mx1.freebsd.org (Postfix) with ESMTP id 763EE8FC18;
	Tue,  3 Jan 2012 11:35:48 +0000 (UTC)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id q03BZZ4I007532;
	Tue, 3 Jan 2012 03:35:39 -0800 (PST)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <201201031135.q03BZZ4I007532@gw.catspoiler.org>
Date: Tue, 3 Jan 2012 03:35:35 -0800 (PST)
From: Don Lewis <truckman@FreeBSD.org>
To: kostikbel@gmail.com
In-Reply-To: <20120103111618.GP50300@deviant.kiev.zoral.com.ua>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
Cc: attilio@FreeBSD.org, flo@FreeBSD.org, current@FreeBSD.org,
	mckusick@mckusick.com, phk@phk.freebsd.dk, seanbru@yahoo-inc.com
Subject: Re: dogfooding over in clusteradm land
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jan 2012 11:35:48 -0000

On  3 Jan, Kostik Belousov wrote:

>> With your change above, the code will skip the busy page after sleeping
>> if it is running in async mode.  It won't make another attempt to write
>> this page because it no longer attempts to rescan.
> Why would it skip it ? Please note the call to vm_page_find_least()
> with the pindex of the busy page right after the check for
> generation. If a page with the pindex is still present in the object,
> vm_page_find_least() should return it, and vm_object_page_clean() should
> make another attempt at processing it.
> 
> Am I missing something ?

Nope, I was missing something ...