From owner-freebsd-current@freebsd.org Fri Feb 26 16:11:16 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A18275655BA for ; Fri, 26 Feb 2021 16:11:16 +0000 (UTC) (envelope-from tsoome@me.com) Received: from pv50p00im-ztbu10021601.me.com (pv50p00im-ztbu10021601.me.com [17.58.6.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnF5J3Yv9z4TXX for ; Fri, 26 Feb 2021 16:11:16 +0000 (UTC) (envelope-from tsoome@me.com) Received: from nazgul.lan (148-52-235-80.sta.estpak.ee [80.235.52.148]) by pv50p00im-ztbu10021601.me.com (Postfix) with ESMTPSA id 33F376E0738; Fri, 26 Feb 2021 16:11:06 +0000 (UTC) From: Toomas Soome Message-Id: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: testers needed: loader: use display pixel density for font autoselection Date: Fri, 26 Feb 2021 18:11:02 +0200 In-Reply-To: <202102261556.11QFuMY4030821@gndrsh.dnsmgr.net> Cc: rgrimes@freebsd.org, Jakob Alvermark , FreeBSD Developers , freebsd-current To: "Rodney W. Grimes" References: <202102261556.11QFuMY4030821@gndrsh.dnsmgr.net> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-02-26_05:2021-02-26, 2021-02-26 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=730 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2006250000 definitions=main-2102260122 X-Rspamd-Queue-Id: 4DnF5J3Yv9z4TXX X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 16:11:16 -0000 > On 26. Feb 2021, at 17:56, Rodney W. Grimes = wrote: >=20 >>> On 26. Feb 2021, at 05:42, Rodney W. Grimes = wrote: >>>=20 >>>>> On 23. Feb 2021, at 17:53, Jakob Alvermark = wrote: >>>>>=20 >>>>> On 2/23/21 12:27 PM, Toomas Soome via freebsd-current wrote: >>>>>> hi! >>>>>>=20 >>>>>> I have done some work to make font pickup a bit smarter = (hopefully better;), but my own ability to test is limited to one bugged = supermicro and one MBP with retina display? >>>>>>=20 >>>>>> The phab link ishttps://reviews.freebsd.org/D28849 = >>>>>>=20 >>>>>> I have built loader binaries as well (bios and uefi): >>>>>> loader_lua >>>>>> loader_lua.efi >>>>>>=20 >>>>>> To test, you should remove screen.font=3D line from loader.conf = and test with different resolutions. >>>>>>=20 >>>>>> thanks, >>>>>> toomas >>>>>=20 >>>>>=20 >>>>>=20 >>>>> Hi Toomas, >>>>>=20 >>>>>=20 >>>>> I tested on five different setups. >>>>>=20 >>>>> Surface Pro 10.6"@1920x1080: >>>>>=20 >>>>> The loader menu looks different, the "FreeBSD" text is on the = right side of the screen. >>>>=20 >>>>=20 >>>> I think, this was the lua script bug we did fix not too long time = ago. >>>>=20 >>>>>=20 >>>>> Otherwise, the font size is what I would call a normal size. >>>>>=20 >>>>>=20 >>>>> Acer laptop 11.6"@1366x768: >>>>>=20 >>>>> Menu looks fine. Almost fills the entire screen. >>>>>=20 >>>>> The font feels a little too big. >>>>=20 >>>>=20 >>>> The laptop built in displays usually do not give out EDID (we get = physical dimensions from EDID), so there we fall back to try to get = 80x25 terminal method. >>>=20 >>> I am having a hard time with that statement. EDID is very common on = laptop screens, infact I can not recall ever not seeing EDID on a = laptops builtin screen. >>> My 11" acer 1400 has EDID in it. >>>=20 >>>=20 >>=20 >>=20 >> If there is EDID, then it is all good. I have seen cases we do not = get it with available API. >=20 > Is there a way for me to know if the laoder found EDID data or not? > It might be that the issue is that what ever loader is using for an = API is not working. > I based my "EDID is very common on laptop screens" on the fact that = X11 almost always finds EDID. >=20 Yes, gop get / vbe list =E2=80=94 yes, it is inconsistent, should fix = at some point=E2=80=A6 :) we do use gop get active edid/get discovered edid protocol and vbe = function 0x4f15. rgds, toomas=